Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lifecycle-operator): propagate metadata from deployment annotations #2832

Merged
merged 16 commits into from
Jan 22, 2024

Conversation

bacherfl
Copy link
Member

Closes #2579

@github-actions github-actions bot added documentation Improvements or additions to documentation lifecycle-operator ops labels Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fecf56b) 85.62% compared to head (6453d88) 85.70%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2832      +/-   ##
==========================================
+ Coverage   85.62%   85.70%   +0.08%     
==========================================
  Files         160      161       +1     
  Lines       10140    10181      +41     
==========================================
+ Hits         8682     8726      +44     
+ Misses       1176     1174       -2     
+ Partials      282      281       -1     
Files Coverage Δ
...e-operator/apis/lifecycle/v1beta1/common/common.go 100.00% <ø> (ø)
...ator/apis/lifecycle/v1beta1/keptnworkload_types.go 88.88% <ø> (ø)
...erator/controllers/common/telemetry/spanhandler.go 86.66% <100.00%> (+2.88%) ⬆️
.../controllers/lifecycle/keptnworkload/controller.go 69.41% <100.00%> (+0.36%) ⬆️
...llers/lifecycle/keptnworkloadversion/controller.go 90.11% <100.00%> (+0.19%) ⬆️
...or/webhooks/pod_mutator/handlers/pod_annotation.go 77.14% <100.00%> (+0.44%) ⬆️
...operator/webhooks/pod_mutator/handlers/workload.go 98.79% <100.00%> (+0.16%) ⬆️
...cle-operator/controllers/common/context/context.go 93.33% <93.33%> (ø)

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 56.63% <100.00%> (+0.45%) ⬆️
lifecycle-operator 84.68% <95.12%> (+0.06%) ⬆️
metrics-operator 87.65% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

bacherfl and others added 6 commits January 18, 2024 11:13
Signed-off-by: Florian Bacher <[email protected]>
check-spelling run (pull_request_target) for feat/metadata-annotations-workload

Signed-off-by: check-spelling-bot <[email protected]>
on-behalf-of: @check-spelling <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl force-pushed the feat/metadata-annotations-workload branch from 34f2619 to dc2ccd3 Compare January 18, 2024 10:13
…ations-workload

# Conflicts:
#	.github/scripts/.helm-tests/default/result.yaml
#	.github/scripts/.helm-tests/lifecycle-only/result.yaml
#	.github/scripts/.helm-tests/lifecycle-with-certs/result.yaml
#	lifecycle-operator/chart/templates/keptnworkload-crd.yaml
Signed-off-by: Florian Bacher <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bacherfl bacherfl marked this pull request as ready for review January 19, 2024 09:17
@bacherfl bacherfl requested review from a team as code owners January 19, 2024 09:17
@bacherfl bacherfl merged commit 6f700ce into keptn:main Jan 22, 2024
43 checks passed
@bacherfl bacherfl deleted the feat/metadata-annotations-workload branch January 22, 2024 08:37
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
…ons (keptn#2832)

Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: check-spelling-bot <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lifecycle-operator ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply metadata from pod annotations to KeptnWorkloadVersion
4 participants