Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade download artifact action #2771

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jan 9, 2024

fix this annoying integration test failures due to artifacts download

@RealAnna RealAnna requested a review from a team as a code owner January 9, 2024 09:52
@github-actions github-actions bot added the ops label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e7751a) 86.56% compared to head (e9d3d5a) 86.62%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2771      +/-   ##
==========================================
+ Coverage   86.56%   86.62%   +0.06%     
==========================================
  Files         169      169              
  Lines       11178    11178              
==========================================
+ Hits         9676     9683       +7     
+ Misses       1220     1215       -5     
+ Partials      282      280       -2     

see 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <ø> (ø)
component-tests 57.12% <ø> (+1.03%) ⬆️
lifecycle-operator 86.28% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

bacherfl
bacherfl previously approved these changes Jan 9, 2024
bacherfl
bacherfl previously approved these changes Jan 9, 2024
odubajDT
odubajDT previously approved these changes Jan 9, 2024
@RealAnna RealAnna dismissed stale reviews from odubajDT and bacherfl via e9d3d5a January 9, 2024 10:16
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@odubajDT odubajDT merged commit fd7b534 into main Jan 9, 2024
31 checks passed
@odubajDT odubajDT deleted the chore/downgrade-download-action branch January 9, 2024 10:34
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants