Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link to Slack channel #2749

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Conversation

JanaganSaravanan
Copy link
Contributor

@JanaganSaravanan JanaganSaravanan commented Jan 3, 2024

Removed the odl link and add new cloud native slack link which is https://cloud-native.slack.com/archives/C017GAX90GM.

Description

Removed the odl link and add new cloud native slack link which is https://cloud-native.slack.com/archives/C017GAX90GM.

Fixes #2747

How to test

Please describe how to run the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also provide information about any automatic tests that you added.

  • Manual Test A
  • Unit Test B
  • Integration Test C

Checklist

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)
    see Contribution Guide
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation (if needed)
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
  • New and existing unit and integration tests pass locally with my changes

Summary

Fixes # (issue)

Checks

  • [] My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • [] I used descriptive commit messages to help reviewers understand my thought process
  • [ ]I signed off all my commits according to the Developer Certificate of Origin (DCO)(
    see Contribution Guide)
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My content follows the style guidelines of this project (YAMLLint, markdown-lint)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my content including grammar and typo errors and also checked the rendered page
    from the Netlify deploy preview
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)

Removed the odl link and add new cloud native slack link which is  https://cloud-native.slack.com/archives/C017GAX90GM. 

Signed-off-by: Janagan Saravanan <[email protected]>
@JanaganSaravanan JanaganSaravanan requested review from a team as code owners January 3, 2024 00:49
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 3, 2024
@agardnerIT agardnerIT changed the title Update CONTRIBUTING.md docs: update CONTRIBUTING.md Jan 3, 2024
@agardnerIT
Copy link
Contributor

Thanks for the PR. This should close #2747

bacherfl
bacherfl previously approved these changes Jan 3, 2024
@bacherfl bacherfl changed the title docs: update CONTRIBUTING.md docs: update link to Slack channel Jan 3, 2024
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! You need to resolve the spelling errors. It doesn't look like these are typos -- more tech terms that may need to be added to the appropriate dictionary.
.
Then one suggestion for the text

Remove links to #help-contributing and #keptn-docs as suggested by @StackScribe

Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

Copy link
Contributor Author

@JanaganSaravanan JanaganSaravanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the slack link.

@StackScribe StackScribe merged commit 14b470b into keptn:main Jan 4, 2024
10 checks passed
Vickysomtee pushed a commit to Vickysomtee/keptn-lifecycle-toolkit that referenced this pull request Apr 23, 2024
Signed-off-by: Janagan Saravanan <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
Co-authored-by: Florian Bacher <[email protected]>
Co-authored-by: Adam Gardner <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: vickysomtee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: CONTRIBUTING.md dead link (PR merge blocker)
4 participants