-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cert-manager): introduce a no-op implementation of ICertificateWatcher #2708
feat(cert-manager): introduce a no-op implementation of ICertificateWatcher #2708
Conversation
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @odubajDT Here is the PR could you please review |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2708 +/- ##
==========================================
- Coverage 85.48% 85.43% -0.05%
==========================================
Files 155 155
Lines 10175 10178 +3
==========================================
- Hits 8698 8696 -2
- Misses 1198 1202 +4
- Partials 279 280 +1
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
…_check_keptn-cert-manager
Signed-off-by: geoffrey1330 <[email protected]>
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
Part-of #2634
Checklist
into multiple PRs)
see Contribution Guide
the Contribution Guide