Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cert-manager): introduce a no-op implementation of ICertificateWatcher #2708

Conversation

geoffrey1330
Copy link
Member

@geoffrey1330 geoffrey1330 commented Dec 20, 2023

Part-of #2634

Checklist

  • My PR fulfills the Definition of Done of the corresponding issue and not more (or parts if the issue is separated
    into multiple PRs)
  • I used descriptive commit messages to help reviewers understand my thought process
  • I signed off all my commits according to the Developer Certificate of Origin (DCO)
    see Contribution Guide
  • My PR title is formatted according to the semantic PR conventions described in
    the Contribution Guide
  • My code follows the style guidelines of this project (golangci-lint passes, YAMLLint passes)
  • I regenerated the auto-generated docs for Helm and the CRD documentation (if applicable)
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation (if needed)
  • My changes result in all-green PR checks (first-time contributors need to ask a maintainer to approve their test runs)
  • New and existing unit and integration tests pass locally with my changes

Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
@geoffrey1330 geoffrey1330 requested a review from a team as a code owner December 20, 2023 09:13
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit e330338
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6582b15d8ed3280008371888
😎 Deploy Preview https://deploy-preview-2708--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@geoffrey1330
Copy link
Member Author

Hi @odubajDT Here is the PR could you please review

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aa1abf0) 85.48% compared to head (c191b99) 85.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
- Coverage   85.48%   85.43%   -0.05%     
==========================================
  Files         155      155              
  Lines       10175    10178       +3     
==========================================
- Hits         8698     8696       -2     
- Misses       1198     1202       +4     
- Partials      279      280       +1     
Files Coverage Δ
keptn-cert-manager/pkg/certificates/watcher.go 60.00% <66.66%> (+0.25%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.42% <66.66%> (-0.01%) ⬇️
component-tests 56.08% <ø> (-0.28%) ⬇️
lifecycle-operator 84.44% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@geoffrey1330 geoffrey1330 changed the title chore: disable keptn cert manager secret check by implementing a no-op of ICertificateWatcher keptn cert manager chore: disable keptn cert manager secret check by implementing a no-op of ICertificateWatcher in keptn-cert-manager Dec 20, 2023
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odubajDT odubajDT changed the title chore: disable keptn cert manager secret check by implementing a no-op of ICertificateWatcher in keptn-cert-manager feat(keptn-cert-manager): introduce a no-op implementation of ICertificateWatcher Dec 20, 2023
@odubajDT odubajDT changed the title feat(keptn-cert-manager): introduce a no-op implementation of ICertificateWatcher feat(cert-manager): introduce a no-op implementation of ICertificateWatcher Dec 20, 2023
@odubajDT odubajDT merged commit 6b5f424 into keptn:main Dec 20, 2023
38 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants