chore: clean up unused volumes #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: odubajDT <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2638 +/- ##
==========================================
- Coverage 85.51% 85.48% -0.03%
==========================================
Files 155 155
Lines 10175 10175
==========================================
- Hits 8701 8698 -3
- Misses 1196 1198 +2
- Partials 278 279 +1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
approved these changes
Dec 5, 2023
bacherfl
approved these changes
Dec 5, 2023
This was referenced Dec 5, 2023
ahmedavid
pushed a commit
to ahmedavid/lifecycle-toolkit
that referenced
this pull request
Dec 6, 2023
Signed-off-by: odubajDT <[email protected]> Signed-off-by: David Ahmadov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some volumes in lifecycle-operator and metrics-operator Deployments are not used, we can remove them