Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mention KEPTN_CONTEXT env var in runtime readmes files #2588

Merged
merged 3 commits into from
Nov 28, 2023
Merged

docs: mention KEPTN_CONTEXT env var in runtime readmes files #2588

merged 3 commits into from
Nov 28, 2023
+19 −4

Conversation

bacherfl
Copy link
Member

Closes #2492

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 27, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 05127d5
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65648463dbc7700008e886b4
😎 Deploy Preview https://deploy-preview-2588--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bacherfl bacherfl marked this pull request as ready for review November 27, 2023 11:16
@bacherfl bacherfl requested a review from a team as a code owner November 27, 2023 11:16
odubajDT
odubajDT previously approved these changes Nov 27, 2023
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mowies
mowies requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls also adapt the relevant docs sections

@bacherfl
Copy link
Member Author

pls also adapt the relevant docs sections

That was done in the feature PR already, at least this was the only section mentioning the context env var: https://github.com/keptn/lifecycle-toolkit/blob/main/docs/content/en/docs/guides/tasks.md#context

@StackScribe StackScribe mentioned this pull request Nov 28, 2023
Closed
@bacherfl bacherfl merged commit dfefc90 into keptn:main Nov 28, 2023
13 checks passed
@bacherfl bacherfl deleted the doc/adapt-keptn-context-env-var branch November 28, 2023 12:02
This was referenced Nov 28, 2023
Merged
Merged
ahmedavid pushed a commit to ahmedavid/lifecycle-toolkit that referenced this pull request Dec 6, 2023
@bacherfl @ahmedavid
docs: mention KEPTN_CONTEXT env var in runtime readmes files (keptn…
d668faa 
…#2588)

Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: David Ahmadov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@mowies mowies mowies approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt docs for new KEPTN_CONTEXT env variables
3 participants
@bacherfl @mowies @odubajDT