docs: remove old observability and orchestrate get-started guides #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meg McRoberts <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2583 +/- ##
==========================================
- Coverage 85.59% 85.48% -0.11%
==========================================
Files 155 155
Lines 10175 10175
==========================================
- Hits 8709 8698 -11
- Misses 1190 1198 +8
- Partials 276 279 +3 see 3 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
mowies
reviewed
Nov 28, 2023
StackScribe
commented
Dec 7, 2023
Signed-off-by: Meg McRoberts [email protected] Signed-off-by: Meg McRoberts <[email protected]>
StackScribe
commented
Dec 11, 2023
Signed-off-by: Meg McRoberts [email protected] Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
|
@StackScribe can you please resolve the conflict? Generally the PR looks good, but with the conflicts we are not able to approve it |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
mowies
requested changes
Dec 13, 2023
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
mowies
reviewed
Dec 13, 2023
Signed-off-by: Meg McRoberts [email protected] Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Meg McRoberts <[email protected]>
|
mowies
approved these changes
Dec 14, 2023
bacherfl
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes two of the old "Getting started" guides - the ones that were listed under "Core Concepts" (previously "Introduction"). Before deleting these, I compared the contents to the other docs and made a couple small changes but really didn't find much in these old guides that we need.
These changes were originally orchestrated under the old docs directory. Those changes were then copied into the docs-new tree with the following exceptions:
Fixes #2505
Fixes #2506
Checks
into multiple PRs)
see Contribution Guide)
the Contribution Guide
from the Netlify deploy preview