feat(lifecycle-operator): add Helm value for DORA metrics port #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ahmedavid
changed the title
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
Signed-off-by: David Ahmadov <[email protected]> Signed-off-by: Griffin <[email protected]>
Signed-off-by: David Ahmadov <[email protected]> Signed-off-by: Griffin <[email protected]>
Signed-off-by: Griffin <[email protected]>
prakrit55
force-pushed
the
feature/keptnDoraMetricsPort
branch
from
5bc62f9 to
280adb1
Compare
Signed-off-by: David Ahmadov <[email protected]>
Signed-off-by: David Ahmadov <[email protected]>
Signed-off-by: David Ahmadov <[email protected]>
mowies
reviewed
Nov 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2571 +/- ##
==========================================
- Coverage 85.48% 85.44% -0.05%
==========================================
Files 155 155
Lines 10177 10175 -2
==========================================
- Hits 8700 8694 -6
- Misses 1198 1201 +3
- Partials 279 280 +1 see 68 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
mowies
reviewed
Nov 28, 2023
mowies
changed the title
Signed-off-by: David Ahmadov <[email protected]>
chage prom to prometheus Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: David Ahmadov <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: David Ahmadov <[email protected]>
mowies
changed the title
Signed-off-by: Moritz Wiesinger <[email protected]>
github-actions
bot
added
the
documentation
|
Kudos, SonarCloud Quality Gate passed!
|
mowies
approved these changes
Nov 28, 2023
odubajDT
approved these changes
Nov 28, 2023
|
Thanks for the contribution @ahmedavid @prakrit55 !! 🎉 |
ahmedavid
added a commit
to ahmedavid/lifecycle-toolkit
that referenced
this pull request
Dec 6, 2023
…#2571) Co-authored-by: Griffin <[email protected]> Co-authored-by: David Ahmadov <[email protected]> Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: David Ahmadov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to specify metrics port via environment variable KEPTN_DORA_METRICS_PORT
which defaults to 2222 if not present.
To verify, I deployed to cluster and ran
Both showed successful reply
Fixes #2541