Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: restructure content #2522

Merged
merged 12 commits into from
Nov 21, 2023
Merged

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Nov 17, 2023

Fixes #2490

@github-actions github-actions bot added documentation Improvements or additions to documentation ops labels Nov 17, 2023
Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 1a3b9a2
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/655c9ef0214408000827ba21
😎 Deploy Preview https://deploy-preview-2522--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2522 (1a3b9a2) into main (a7322bd) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2522   +/-   ##
=======================================
  Coverage   85.51%   85.51%           
=======================================
  Files         155      155           
  Lines       10177    10177           
=======================================
  Hits         8703     8703           
  Misses       1196     1196           
  Partials      278      278           
Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 57.09% <ø> (ø)
lifecycle-operator 84.44% <ø> (ø)
metrics-operator 87.43% <ø> (ø)
scheduler 36.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@thisthat thisthat changed the title add test workflow trigger release docs docs: restructure content Nov 17, 2023
@github-actions github-actions bot added ops and removed ops labels Nov 17, 2023
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat force-pushed the docs/2490/new-docs-structure branch from fdf9c73 to 44c59c2 Compare November 17, 2023 11:16
@thisthat thisthat marked this pull request as ready for review November 17, 2023 11:16
@thisthat thisthat requested review from a team as code owners November 17, 2023 11:16
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reset the weights for the implementing folder. This spreads the range of numbers used, assigns a unique weight to each file, and groups the pages into general (0xx), metrics-operator (2xx), and lifecycle-operator (3xx)

docs/content/en/docs/guides/slo.md Outdated Show resolved Hide resolved
docs/content/en/docs/guides/otel.md Show resolved Hide resolved
docs/content/en/docs/guides/integrate.md Outdated Show resolved Hide resolved
docs/content/en/docs/guides/evaluations.md Outdated Show resolved Hide resolved
docs/content/en/docs/guides/evaluatemetrics.md Outdated Show resolved Hide resolved
docs/content/en/docs/guides/dora.md Show resolved Hide resolved
docs/content/en/docs/guides/auto-app-discovery.md Outdated Show resolved Hide resolved
docs/content/en/docs/guides/tasks.md Outdated Show resolved Hide resolved
@StackScribe
Copy link
Contributor

Why is API Reference at the top level whereas the CRD Reference is buried two clicks down? I was skeptical about combining the architectural info with the CRE Reference and I really don't like how it looks now. The Architectural info should be somewhat esoteric information for sophisticated and curious users whereas the CRD Reference is material that regular users will use daily, once they are familiar with Keptn and not needing to look through the guides.

@StackScribe
Copy link
Contributor

Why are the "Scheduler and Scheduling Gates" pages under metrics-operator in Components?

odubajDT
odubajDT previously approved these changes Nov 20, 2023
Signed-off-by: Giovanni Liva <[email protected]>
@mowies
Copy link
Member

mowies commented Nov 21, 2023

Why is API Reference at the top level whereas the CRD Reference is buried two clicks down? I was skeptical about combining the architectural info with the CRE Reference and I really don't like how it looks now. The Architectural info should be somewhat esoteric information for sophisticated and curious users whereas the CRD Reference is material that regular users will use daily, once they are familiar with Keptn and not needing to look through the guides.

@StackScribe moving the API reference into the component sections will be done in #2494

@mowies
Copy link
Member

mowies commented Nov 21, 2023

Why are the "Scheduler and Scheduling Gates" pages under metrics-operator in Components?

@StackScribe @thisthat that looks like a mistake to me and should be fixed

EDIT: no looking at the preview, it seems fine. the 2 most important components at the top (metrics, lifecycle operator), then scheduler and cert operator

odubajDT
odubajDT previously approved these changes Nov 21, 2023
@StackScribe
Copy link
Contributor

Why are the "Scheduler and Scheduling Gates" pages under metrics-operator in Components?

@StackScribe @thisthat that looks like a mistake to me and should be fixed

EDIT: no looking at the preview, it seems fine. the 2 most important components at the top (metrics, lifecycle operator), then scheduler and cert operator

Ah, in the left frame, it looks like scheduling and cert-manager are under metrics-operator but it's just because top-level pages with no subsections are being rendered differently in the left fram TOC.

@StackScribe
Copy link
Contributor

I still really dislike having the reference pages buried so they don't show on the top level. Would you consider a top-leve header of "Reference pages" with subsections for the components and then the CRD and API ref pages under those?

@mowies
Copy link
Member

mowies commented Nov 21, 2023

ok then let's try out a top level section called "reference" and put the api and crd reference inside that. i'll do that now

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mowies mowies merged commit c2d8bd9 into keptn:main Nov 21, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New structure for documentation
5 participants