-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: restructure content #2522
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
=======================================
Coverage 85.51% 85.51%
=======================================
Files 155 155
Lines 10177 10177
=======================================
Hits 8703 8703
Misses 1196 1196
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
Signed-off-by: Giovanni Liva <[email protected]>
fdf9c73
to
44c59c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reset the weights for the implementing folder. This spreads the range of numbers used, assigns a unique weight to each file, and groups the pages into general (0xx), metrics-operator (2xx), and lifecycle-operator (3xx)
Why is API Reference at the top level whereas the CRD Reference is buried two clicks down? I was skeptical about combining the architectural info with the CRE Reference and I really don't like how it looks now. The Architectural info should be somewhat esoteric information for sophisticated and curious users whereas the CRD Reference is material that regular users will use daily, once they are familiar with Keptn and not needing to look through the guides. |
Why are the "Scheduler and Scheduling Gates" pages under metrics-operator in Components? |
Signed-off-by: Giovanni Liva <[email protected]>
@StackScribe moving the API reference into the component sections will be done in #2494 |
@StackScribe @thisthat that looks like a mistake to me and should be fixed EDIT: no looking at the preview, it seems fine. the 2 most important components at the top (metrics, lifecycle operator), then scheduler and cert operator |
Ah, in the left frame, it looks like scheduling and cert-manager are under metrics-operator but it's just because top-level pages with no subsections are being rendered differently in the left fram TOC. |
I still really dislike having the reference pages buried so they don't show on the top level. Would you consider a top-leve header of "Reference pages" with subsections for the components and then the CRD and API ref pages under those? |
ok then let's try out a top level section called "reference" and put the api and crd reference inside that. i'll do that now |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixes #2490