Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more dictionaries to spell checker action #2449

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 8, 2023

Description

This PR adds the k8s and the go dictionary to the spell checker action since those are relevant for this repo.

(the spell check on the PR will be green after merging, tested in fork)

Part of #2291

@mowies mowies requested a review from a team as a code owner November 8, 2023 08:55
@github-actions github-actions bot added the ops label Nov 8, 2023
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 97e966c
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/654b4ce6a0192000087a8308
😎 Deploy Preview https://deploy-preview-2449--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2449 (f00f583) into main (fe7904d) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2449      +/-   ##
==========================================
+ Coverage   85.71%   85.75%   +0.03%     
==========================================
  Files         161      161              
  Lines       10201    10201              
==========================================
+ Hits         8744     8748       +4     
+ Misses       1186     1183       -3     
+ Partials      271      270       -1     

see 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.61% <ø> (+0.27%) ⬆️
lifecycle-operator 86.24% <ø> (ø)
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies merged commit 3ad38bf into keptn:main Nov 8, 2023
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants