Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add config for spell checker action, fix typos #2443

Merged
merged 46 commits into from
Nov 7, 2023
Merged

Conversation

mowies
Copy link
Member

@mowies mowies commented Nov 7, 2023

Description

This PR introduces configuration for the check-spelling/check-spelling GH action that will be added in #2316.
Also, it fixes any errors that are present in the repo right now.

All the spell checker config is under .github/actions/spelling.

Part of #2291

How to test

A successful run (except for an arbitrarily introduced grammar error for PR creation) can be found here: Link

mowies added 30 commits November 7, 2023 15:00
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit d854d34
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/654a4538f5a7e600082bd023
😎 Deploy Preview https://deploy-preview-2443--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2443 (b418730) into main (3185943) will increase coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 85.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2443      +/-   ##
==========================================
+ Coverage   85.68%   85.71%   +0.02%     
==========================================
  Files         161      161              
  Lines       10201    10201              
==========================================
+ Hits         8741     8744       +3     
+ Misses       1188     1186       -2     
+ Partials      272      271       -1     
Files Coverage Δ
...-operator/apis/lifecycle/v1alpha2/common/phases.go 100.00% <ø> (ø)
...-operator/apis/lifecycle/v1alpha3/common/common.go 100.00% <ø> (ø)
...ollers/common/providers/keptnmetric/keptnmetric.go 90.00% <100.00%> (ø)
...rator/controllers/common/taskdefinition/handler.go 100.00% <ø> (ø)
...controllers/lifecycle/keptntask/runtime_builder.go 70.44% <100.00%> (ø)
...controllers/common/analysis/objective_evaluator.go 100.00% <ø> (ø)
metrics-operator/converter/common.go 100.00% <100.00%> (ø)
metrics-operator/converter/sli_converter.go 96.20% <100.00%> (ø)
metrics-operator/converter/slo_converter.go 94.71% <100.00%> (ø)
klt-cert-manager/pkg/certificates/watcher.go 59.74% <50.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <50.00%> (ø)
component-tests 56.33% <0.00%> (-0.35%) ⬇️
keptn-lifecycle-operator ?
lifecycle-operator 86.24% <100.00%> (ø)
metrics-operator 87.58% <100.00%> (ø)
scheduler 32.12% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants