Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert Chart.yaml to point to local repositories #2394

Merged
merged 1 commit into from
Nov 2, 2023
Merged

chore: revert Chart.yaml to point to local repositories #2394

merged 1 commit into from
Nov 2, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Nov 1, 2023

Changes

With the changes made in this commit, any change of the fields in CRDs will cause failure of the test, like here.

Reverting these changes.

Follow-up

#2397

@github-actions github-actions bot added the ops label Nov 1, 2023
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 188f503
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/65424fc128b2e500086bbee9
😎 Deploy Preview https://deploy-preview-2394--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2394 (1fd3cb2) into main (66668f5) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
- Coverage   85.50%   85.49%   -0.01%     
==========================================
  Files         161      161              
  Lines       10166    10166              
==========================================
- Hits         8692     8691       -1     
- Misses       1196     1197       +1     
  Partials      278      278              

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 67.43% <ø> (ø)
component-tests 56.71% <ø> (-0.64%) ⬇️
lifecycle-operator 85.61% <ø> (ø)
metrics-operator 87.58% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review November 1, 2023 13:19
@odubajDT odubajDT requested a review from a team as a code owner November 1, 2023 13:19
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make it mac friendly

@odubajDT odubajDT changed the title test: fix helm-test to consider local changes of helm templates chore: revert Chart.yaml to point to local repositories Nov 2, 2023
@github-actions github-actions bot removed the ops label Nov 2, 2023
Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@odubajDT odubajDT merged commit ff3bdb1 into keptn:main Nov 2, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants