Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add required labels to required CRD fields (KeptnApp, KeptnConfig, KeptnEvaluationDefinition) #2390

Merged
merged 4 commits into from
Oct 31, 2023
Merged

docs: add required labels to required CRD fields (KeptnApp, KeptnConfig, KeptnEvaluationDefinition) #2390

merged 4 commits into from
Oct 31, 2023

Conversation

odubajDT
Copy link
Contributor

Part-of: #2324

@odubajDT
docs: add required labels to required CRD fields (KeptnApp, KeptnConf…
7642392 
…ig, KeptnEvaluationDefinition)

Signed-off-by: odubajDT <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 31, 2023
@netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 60214f2
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6541053a1e1f200008f3b1a8
😎 Deploy Preview https://deploy-preview-2390--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@odubajDT
fix linter
dc51d9f 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT marked this pull request as ready for review October 31, 2023 13:26
@odubajDT odubajDT requested review from a team as code owners October 31, 2023 13:26
mowies
mowies previously approved these changes Oct 31, 2023
View reviewed changes
@mowies @StackScribe
Update docs/content/en/docs/yaml-crd-ref/evaluationdefinition.md
46ae10a 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@odubajDT @StackScribe
Apply suggestions from code review
60214f2 
Co-authored-by: Meg McRoberts <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@RealAnna RealAnna merged commit 5c7b0cd into keptn:main Oct 31, 2023
14 checks passed
@keptn-bot keptn-bot mentioned this pull request Oct 31, 2023
Merged
StackScribe
StackScribe reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Differences between versions" sections needs to show when the CloudEvents stuff is added.

@mowies mowies mentioned this pull request Oct 31, 2023
Closed
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StackScribe StackScribe StackScribe left review comments

@RealAnna RealAnna RealAnna approved these changes

@mowies mowies mowies approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odubajDT @StackScribe @mowies @RealAnna