Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add required labels to required CRD fields (KeptnTask, KeptnMetric, KeptnMetricsProvider, KeptnTaskDefintion) #2388

Merged
merged 5 commits into from
Oct 31, 2023
Merged

docs: add required labels to required CRD fields (KeptnTask, KeptnMetric, KeptnMetricsProvider, KeptnTaskDefintion) #2388

merged 5 commits into from
Oct 31, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Oct 31, 2023 •
edited
Loading

This PR

  • adds required labels for required fields in the CRD reference pages for the following types:
    • KeptnTask
    • KeptnMetric
    • KeptnMetricsProvider
    • KeptnTaskDefintion

Part-of: #2324

@mowies
add testing required label
a9174d1 
Signed-off-by: Moritz Wiesinger <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 31, 2023
@mowies mowies marked this pull request as ready for review October 31, 2023 11:01
@mowies mowies requested review from a team as code owners October 31, 2023 11:01
@mowies
more testing
4e4d98f 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies closed this Oct 31, 2023
@mowies mowies reopened this Oct 31, 2023
@netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 2489ab0
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6540ffa6e2a2de000853125a
😎 Deploy Preview https://deploy-preview-2388--keptn-lifecycle-toolkit.netlify.app/docs/yaml-crd-ref/taskdefinition
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

StackScribe
StackScribe previously approved these changes Oct 31, 2023
View reviewed changes
@mowies
add required labels to keptn metric
5ffe824 
Signed-off-by: Moritz Wiesinger <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies changed the title docs: add required labels to required CRD fields docs: add required labels to required CRD fields (KeptnTask, KeptnMetric, KeptnMetricsProvider, KeptnTaskDefintion) Oct 31, 2023
@mowies mowies merged commit 0e39c0e into keptn:main Oct 31, 2023
20 checks passed
@mowies mowies deleted the required-fields-in-crd-ref-pages branch October 31, 2023 13:52
@keptn-bot keptn-bot mentioned this pull request Oct 31, 2023
Merged
@mowies mowies mentioned this pull request Oct 31, 2023
Closed
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@RealAnna RealAnna RealAnna approved these changes

@StackScribe StackScribe StackScribe left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mowies @StackScribe @RealAnna @odubajDT