chore: use templated values in install action and security workflow #2366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RealAnna
force-pushed
the
fix/use_templated_values
branch
from
804c5bf to
22c9823
Compare
github-actions
bot
removed
documentation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2366 +/- ##
==========================================
- Coverage 85.53% 85.50% -0.03%
==========================================
Files 161 161
Lines 10166 10166
==========================================
- Hits 8695 8692 -3
- Misses 1194 1196 +2
- Partials 277 278 +1 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
RealAnna
changed the title
|
Please let's merge this one before #2334 |
mowies
previously approved these changes
Oct 30, 2023
|
If possible please adapt security-scan workflow as well? But it can be done in a follow-up as well, up to you |
odubajDT
previously approved these changes
Nov 2, 2023
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: odubajDT <[email protected]>
odubajDT
force-pushed
the
fix/use_templated_values
branch
from
91e7c7d to
03a685b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Nov 3, 2023
odubajDT
changed the title
bacherfl
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2182
Security run: https://github.com/keptn/lifecycle-toolkit/actions/runs/6745011001