Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove empty and outdated pages #2332

Merged
merged 5 commits into from
Oct 25, 2023
Merged

docs: remove empty and outdated pages #2332

merged 5 commits into from
Oct 25, 2023

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Oct 25, 2023 •
edited
Loading

Fixes #2323

@thisthat
docs: remove empty pages
ea3fef9 
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat thisthat requested review from a team as code owners October 25, 2023 11:12
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 2d36812
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6539082b4591ef0008d18c60
😎 Deploy Preview https://deploy-preview-2332--keptn-lifecycle-toolkit.netlify.app/docs/intro/usecase-orchestrate
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mowies
mowies previously approved these changes Oct 25, 2023
View reviewed changes
@mowies mowies changed the title docs: remove empty pages docs: remove empty and outdated pages Oct 25, 2023
@thisthat
revert cert-manager
f8220ce 
Signed-off-by: Giovanni Liva <[email protected]>
@thisthat
newline
5b3b94c 
Signed-off-by: Giovanni Liva <[email protected]>
mowies
mowies previously approved these changes Oct 25, 2023
View reviewed changes
RealAnna
RealAnna requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert K8s versions in scheduling gates 😞

@thisthat
fixups
80dab65 
Signed-off-by: Giovanni Liva <[email protected]>
RealAnna
RealAnna previously approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

odubajDT
odubajDT requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please check the failing link CI check?

@thisthat
deadlinks
2d36812 
Signed-off-by: Giovanni Liva <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thisthat thisthat merged commit 3077e31 into keptn:main Oct 25, 2023
17 checks passed
@thisthat thisthat deleted the docs/2323/remove-empty-pages branch October 25, 2023 12:58
@keptn-bot keptn-bot mentioned this pull request Oct 25, 2023
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mowies mowies mowies left review comments

@odubajDT odubajDT odubajDT approved these changes

@RealAnna RealAnna RealAnna approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove empty pages
4 participants
@thisthat @mowies @RealAnna @odubajDT