Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add KeptnApp reference in getting started #2202

Merged
merged 6 commits into from
Oct 4, 2023
Merged

docs: add KeptnApp reference in getting started #2202

merged 6 commits into from
Oct 4, 2023

Conversation

prakrit55
Copy link
Member

@prakrit55 prakrit55 commented Sep 29, 2023 •
edited
Loading

Fixes #2116

  • add KeptnApp reference to getting started guide

@prakrit55 prakrit55 requested review from a team as code owners September 29, 2023 10:33
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 29, 2023
@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 1cce32f
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/651d0a0cb897ef000848dbc6
😎 Deploy Preview https://deploy-preview-2202--keptn-lifecycle-toolkit.netlify.app/docs/getting-started
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prakrit55
Copy link
Member Author

Hey @RealAnna, created the KeptnApp reference docs pr for main.

RealAnna
RealAnna previously approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you !

odubajDT
odubajDT requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@odubajDT odubajDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please resolve the problems in the CI? Thank you :)

@RealAnna
Copy link
Contributor

RealAnna commented Oct 2, 2023 •
edited
Loading

@prakrit55 if you check the failing test it seems there are some blank lines at the end of your title or in the section you added, can you fix it please? https://github.com/keptn/lifecycle-toolkit/actions/runs/6352585671/job/17308072223?pr=2202

agardnerIT
agardnerIT previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although @StackScribe may wish to link out to https://lifecycle.keptn.sh/docs/yaml-crd-ref/app/#fields rather than have content duplicated on this page. @StackScribe thoughts?

I'm happy either way and this looks great to merge. Thank you for the PR!

@prakrit55
Copy link
Member Author

Hey @odubajDT, I think the html and markdown checks are failing in most of the documentation prs.

@prakrit55
Update _index.md
00ded7e 
remove commented text

Signed-off-by: Prakriti Mandal <[email protected]>
odubajDT
odubajDT previously requested changes Oct 4, 2023
View reviewed changes
docs/content/en/docs/getting-started/_index.md Outdated Show resolved Hide resolved
@prakrit55
Update _index.md
1cce32f 
correct the links

Signed-off-by: Prakriti Mandal <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

RealAnna
RealAnna approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the errors came from main, this can be merged! Thankyou @prakrit55 🎉

@odubajDT odubajDT merged commit a15b038 into keptn:main Oct 4, 2023
11 of 14 checks passed
@keptn-bot keptn-bot mentioned this pull request Oct 4, 2023
Merged
@prakrit55 prakrit55 deleted the main4 branch October 4, 2023 10:27
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Oct 13, 2023
@prakrit55 @StackScribe
docs: add KeptnApp reference in getting started (keptn#2202)
2cbcd20 
Signed-off-by: Griffin <[email protected]>
Signed-off-by: Prakriti Mandal <[email protected]>
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
@prakrit55 prakrit55 mentioned this pull request Jan 24, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@RealAnna RealAnna RealAnna approved these changes

@agardnerIT agardnerIT agardnerIT left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Quick start needs KeptnApp
4 participants
@prakrit55 @RealAnna @agardnerIT @odubajDT