Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: edit Analysis guide page #2199

Merged
merged 2 commits into from
Sep 29, 2023
Merged

docs: edit Analysis guide page #2199

merged 2 commits into from
Sep 29, 2023

Conversation

StackScribe
Copy link
Contributor

Just a bit of wordsmithing on @RealAnna 's excellent page:

  • Renamed this to be just "Analysis" to match other titles under "User Guides"
  • Modified weight to locate this after OpenTelemetry and before Tasks
  • Expanded the intro a bit
  • Slight restructuring to make it flow better
  • Removing "there is/are" occurrances, replace future tense with present in most cases, enclosed all names of resources in tics, etc

@StackScribe
docs: edit Analysis guide page
4258597 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Sep 29, 2023
@StackScribe StackScribe added this to the 0.9 milestone Sep 29, 2023
@StackScribe StackScribe requested a review from a team as a code owner September 29, 2023 10:09
@StackScribe StackScribe self-assigned this Sep 29, 2023
@StackScribe StackScribe requested a review from a team as a code owner September 29, 2023 10:09
@netlify
Copy link

netlify bot commented Sep 29, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 738ad58
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6516a2848aa0e5000805ac1c
😎 Deploy Preview https://deploy-preview-2199--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@StackScribe
fix typo
738ad58 
Signed-off-by: Meg McRoberts <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@RealAnna
Copy link
Contributor

now it sounds waaay more professional ❤️

@odubajDT odubajDT merged commit 942842b into keptn:main Sep 29, 2023
13 of 14 checks passed
@keptn-bot keptn-bot mentioned this pull request Sep 29, 2023
Merged
@keptn-bot keptn-bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odubajDT odubajDT odubajDT approved these changes

@RealAnna RealAnna RealAnna approved these changes

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.9
Development

Successfully merging this pull request may close these issues.
3 participants
@StackScribe @RealAnna @odubajDT