feat(metrics-operator): add helm chart for metrics operator #2189

RealAnna · 2023-09-27T14:02:23Z

netlify · 2023-09-27T14:02:56Z

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name	Link
🔨 Latest commit	`63b7503`
🔍 Latest deploy log	https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/6516936c294aa800087e6003
😎 Deploy Preview	https://deploy-preview-2189--keptn-lifecycle-toolkit.netlify.app/docs/implementing/evaluations
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2023-09-27T14:04:55Z

Codecov Report

Merging #2189 (410798b) into main (b3b68fa) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2189   +/-   ##
=======================================
  Coverage   84.51%   84.51%           
=======================================
  Files         154      154           
  Lines        9918     9918           
=======================================
  Hits         8382     8382           
  Misses       1249     1249           
  Partials      287      287

Flag	Coverage Δ
certificate-operator	`65.91% <ø> (ø)`
component-tests	`57.82% <ø> (ø)`
lifecycle-operator	`85.02% <ø> (ø)`
metrics-operator	`87.38% <ø> (ø)`
scheduler	`32.12% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

metrics-operator/chart/Chart.yaml

helm/chart/templates/hpa-controller-keptn-metrics-rbac.yaml

helm/chart/templates/metrics-manager-config.yaml

metrics-operator/chart/doc.yaml

metrics-operator/chart/templates/metrics-manager-config.yaml

metrics-operator/chart/templates/metrics-operator-service.yaml

thisthat

I believe also release-please conf needs to be updated to track the value file

RealAnna · 2023-09-28T08:11:34Z

I believe also release-please conf needs to be updated to track the value file

we discussed having all pipeline changes done in a single ticket, @thisthat do you think that is not a good idea? 🤔

thisthat · 2023-09-28T08:17:41Z

I believe also release-please conf needs to be updated to track the value file

we discussed having all pipeline changes done in a single ticket, @thisthat do you think that is not a good idea? 🤔

sorry, I miss that discussion. I am fine doing that in a single PR :)

metrics-operator/chart/Chart.yaml

metrics-operator/chart/values.yaml

.github/scripts/.helm-tests/default/result.yaml

metrics-operator/chart/Chart.yaml

metrics-operator/chart/README.md

metrics-operator/chart/templates/deployment.yaml

metrics-operator/chart/values.yaml

metrics-operator/chart/templates/deployment.yaml

metrics-operator/chart/doc.yaml

metrics-operator/chart/templates/metrics-operator-serviceAccount.yaml

metrics-operator/config/manager/kustomization.yaml

metrics-operator/config/default/manager_config_patch.yaml

Signed-off-by: realanna <[email protected]> removed empty line Signed-off-by: realanna <[email protected]> removed empty line Signed-off-by: realanna <[email protected]> removed empty line Signed-off-by: realanna <[email protected]> removed empty line Signed-off-by: realanna <[email protected]> removed empty line Signed-off-by: realanna <[email protected]> removed empty line Signed-off-by: realanna <[email protected]> adds app.kubernetes.io/component: metrics-operator Signed-off-by: realanna <[email protected]> fix: missing default container Signed-off-by: realanna <[email protected]> Update metrics-operator/config/default/manager_config_patch.yaml Signed-off-by: RealAnna <[email protected]> Update metrics-operator/config/manager/kustomization.yaml Signed-off-by: RealAnna <[email protected]> feat: rename label Signed-off-by: realanna <[email protected]> feat: separate service account Signed-off-by: realanna <[email protected]> feat: separate service account Signed-off-by: realanna <[email protected]> feat: added chart description Signed-off-by: realanna <[email protected]> feat: lint Signed-off-by: realanna <[email protected]> Update metrics-operator/chart/Chart.yaml Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]> Update metrics-operator/chart/Chart.yaml Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: RealAnna <[email protected]> Update metrics-operator/chart/Chart.yaml Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: RealAnna <[email protected]> Update metrics-operator/chart/Chart.yaml Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]> Update metrics-operator/chart/templates/metrics-manager-config.yaml Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]> Update metrics-operator/chart/templates/metrics-operator-service.yaml Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]> feat: lint Signed-off-by: realanna <[email protected]> feat: removed mtrics operator Signed-off-by: realanna <[email protected]> feat: rename manager container Signed-off-by: realanna <[email protected]> feat: remove duplicate Signed-off-by: realanna <[email protected]> feat: remove duplicate Signed-off-by: realanna <[email protected]> feat: remove mod error Signed-off-by: realanna <[email protected]> feat: remove mod error Signed-off-by: realanna <[email protected]> feat: remove mod error Signed-off-by: realanna <[email protected]> feat: remove mod error Signed-off-by: realanna <[email protected]> feat: remove mod error Signed-off-by: realanna <[email protected]> feat: remove mod error Signed-off-by: realanna <[email protected]> feat: remove mod error Signed-off-by: realanna <[email protected]> feat: remove linter Signed-off-by: realanna <[email protected]> feat: remove linter Signed-off-by: realanna <[email protected]> feat: remove linter Signed-off-by: realanna <[email protected]> feat: add install Signed-off-by: realanna <[email protected]> feat: add install Signed-off-by: realanna <[email protected]> feat: fix dep Signed-off-by: realanna <[email protected]> feat: fix values file Signed-off-by: realanna <[email protected]> feat: fix values file Signed-off-by: realanna <[email protected]> feat: add initial metric operator helm chart Signed-off-by: realanna <[email protected]>

odubajDT · 2023-09-29T09:10:27Z

Please remove this file helm/chart/rendered.yaml

Signed-off-by: realanna <[email protected]>

metrics-operator/chart/values.yaml

Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]>

sonarcloud · 2023-09-29T09:30:11Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

RealAnna requested a review from a team as a code owner September 27, 2023 14:02

github-actions bot added documentation Improvements or additions to documentation metrics-operator helm labels Sep 27, 2023

RealAnna marked this pull request as draft September 27, 2023 14:05

github-actions bot added the ops label Sep 27, 2023

RealAnna force-pushed the feat/2181/umbrella_metrics_operator branch from 03d89e7 to 82d4feb Compare September 28, 2023 06:26

RealAnna commented Sep 28, 2023

View reviewed changes

metrics-operator/chart/Chart.yaml Show resolved Hide resolved

RealAnna commented Sep 28, 2023

View reviewed changes

helm/chart/templates/hpa-controller-keptn-metrics-rbac.yaml Outdated Show resolved Hide resolved

RealAnna commented Sep 28, 2023

View reviewed changes

helm/chart/templates/metrics-manager-config.yaml Outdated Show resolved Hide resolved

RealAnna commented Sep 28, 2023

View reviewed changes

metrics-operator/chart/doc.yaml Outdated Show resolved Hide resolved

RealAnna marked this pull request as ready for review September 28, 2023 06:45

bacherfl reviewed Sep 28, 2023

View reviewed changes

metrics-operator/chart/templates/metrics-manager-config.yaml Outdated Show resolved Hide resolved

bacherfl reviewed Sep 28, 2023

View reviewed changes

metrics-operator/chart/templates/metrics-operator-service.yaml Outdated Show resolved Hide resolved

thisthat reviewed Sep 28, 2023

View reviewed changes

metrics-operator/chart/Chart.yaml Outdated Show resolved Hide resolved

metrics-operator/chart/Chart.yaml Outdated Show resolved Hide resolved

metrics-operator/chart/values.yaml Outdated Show resolved Hide resolved

mowies reviewed Sep 28, 2023

View reviewed changes

metrics-operator/chart/templates/deployment.yaml Show resolved Hide resolved

metrics-operator/chart/doc.yaml Outdated Show resolved Hide resolved

metrics-operator/chart/templates/metrics-operator-serviceAccount.yaml Outdated Show resolved Hide resolved

RealAnna commented Sep 28, 2023

View reviewed changes

metrics-operator/config/manager/kustomization.yaml Outdated Show resolved Hide resolved

RealAnna commented Sep 28, 2023

View reviewed changes

metrics-operator/config/default/manager_config_patch.yaml Outdated Show resolved Hide resolved

RealAnna force-pushed the feat/2181/umbrella_metrics_operator branch 2 times, most recently from 91e4230 to a0ba7ad Compare September 28, 2023 13:25

odubajDT previously approved these changes Sep 28, 2023

View reviewed changes

RealAnna requested review from mowies, bacherfl and thisthat September 28, 2023 13:41

RealAnna dismissed odubajDT’s stale review via 63b7503 September 29, 2023 09:05

RealAnna force-pushed the feat/2181/umbrella_metrics_operator branch from a0ba7ad to 63b7503 Compare September 29, 2023 09:05

correct image ref

1087e65

Signed-off-by: realanna <[email protected]>

odubajDT previously approved these changes Sep 29, 2023

View reviewed changes

thisthat reviewed Sep 29, 2023

View reviewed changes

metrics-operator/chart/values.yaml Outdated Show resolved Hide resolved

Update metrics-operator/chart/values.yaml

410798b

Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: RealAnna <[email protected]>

RealAnna dismissed odubajDT’s stale review via 410798b September 29, 2023 09:29

thisthat approved these changes Sep 29, 2023

View reviewed changes

odubajDT approved these changes Sep 29, 2023

View reviewed changes

odubajDT merged commit a5ae3de into main Sep 29, 2023
36 checks passed

odubajDT deleted the feat/2181/umbrella_metrics_operator branch September 29, 2023 09:52

This was referenced Sep 29, 2023

chore: release metrics-operator 0.8.3 #2053

Merged

chore: release klt 0.9.0 #2056

Merged

keptn-bot mentioned this pull request Jan 23, 2024

chore: release keptn 0.10.0 #2563

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(metrics-operator): add helm chart for metrics operator #2189

feat(metrics-operator): add helm chart for metrics operator #2189

RealAnna commented Sep 27, 2023 •

edited

Loading

netlify bot commented Sep 27, 2023 •

edited

Loading

codecov bot commented Sep 27, 2023 •

edited

Loading

thisthat left a comment

RealAnna commented Sep 28, 2023

thisthat commented Sep 28, 2023

odubajDT commented Sep 29, 2023

sonarcloud bot commented Sep 29, 2023

feat(metrics-operator): add helm chart for metrics operator #2189

feat(metrics-operator): add helm chart for metrics operator #2189

Conversation

RealAnna commented Sep 27, 2023 • edited Loading

netlify bot commented Sep 27, 2023 • edited Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

codecov bot commented Sep 27, 2023 • edited Loading

Codecov Report

thisthat left a comment

Choose a reason for hiding this comment

RealAnna commented Sep 28, 2023

thisthat commented Sep 28, 2023

odubajDT commented Sep 29, 2023

sonarcloud bot commented Sep 29, 2023

RealAnna commented Sep 27, 2023 •

edited

Loading

netlify bot commented Sep 27, 2023 •

edited

Loading

codecov bot commented Sep 27, 2023 •

edited

Loading