Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics-operator): flush status when analysis is finished #2122

Merged
merged 8 commits into from
Sep 19, 2023

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Sep 18, 2023

closes #2093

@RealAnna RealAnna requested a review from a team as a code owner September 18, 2023 09:04
@netlify
Copy link

netlify bot commented Sep 18, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit cca59c4
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/650812878f15c20008673c66
😎 Deploy Preview https://deploy-preview-2122--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2122 (c1d8972) into main (34c9d11) will decrease coverage by 30.00%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2122       +/-   ##
===========================================
- Coverage   84.26%   54.26%   -30.00%     
===========================================
  Files         150       22      -128     
  Lines        9597     1699     -7898     
===========================================
- Hits         8087      922     -7165     
+ Misses       1223      691      -532     
+ Partials      287       86      -201     

see 141 files with indirect coverage changes

Flag Coverage Δ
certificate-operator ?
component-tests 58.06% <ø> (-1.11%) ⬇️
lifecycle-operator ?
metrics-operator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@RealAnna
Copy link
Contributor Author

Codecov Report

Merging #2122 (6528160) into main (d08df40) will decrease coverage by 3.42%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

It never fails to surprise me how Codecov can claim there are coverage changes in the lifecycle operator in a PR where only the metrics operator is touched -,-

bacherfl
bacherfl previously approved these changes Sep 18, 2023
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one optional suggestion

odubajDT
odubajDT previously approved these changes Sep 18, 2023
@RealAnna RealAnna dismissed stale reviews from odubajDT and bacherfl via 5c6ca30 September 18, 2023 11:53
odubajDT
odubajDT previously approved these changes Sep 18, 2023
@RealAnna RealAnna force-pushed the fix/2093/flush_status branch from 815038c to c1d8972 Compare September 18, 2023 12:19
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@RealAnna RealAnna merged commit 276b609 into main Sep 19, 2023
36 of 37 checks passed
@RealAnna RealAnna deleted the fix/2093/flush_status branch September 19, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants