Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bootstrap Service CR and controller #21

Merged
merged 11 commits into from
Sep 20, 2022
Merged

feat: Bootstrap Service CR and controller #21

merged 11 commits into from
Sep 20, 2022

Conversation

odubajDT
Copy link
Contributor

Signed-off-by: odubajDT [email protected]

Resolves #10

thschue
thschue requested changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and ownership issues

operator/api/v1alpha1/service_types.go Outdated Show resolved Hide resolved
operator/api/v1alpha1/service_types.go Show resolved Hide resolved
operator/controllers/service_controller.go Outdated Show resolved Hide resolved
operator/controllers/service_controller.go Show resolved Hide resolved
operator/controllers/service_controller.go Outdated Show resolved Hide resolved
operator/controllers/service_controller.go Outdated Show resolved Hide resolved
operator/controllers/service_controller.go Outdated Show resolved Hide resolved
operator/controllers/service_controller.go Show resolved Hide resolved
operator/controllers/event_controller.go Show resolved Hide resolved
operator/controllers/service_controller.go Outdated Show resolved Hide resolved
@odubajDT
feat: Bootstrap Service CR and controller
7ccdeda 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
cleanup
e5d5f43 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix
82ecac6 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
201a942 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
remove dead code
7f9dcc9 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
6ea15a8 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
first version
7aac2a1 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT force-pushed the feat/10/bootstrap-service-controller branch from d201818 to 7aac2a1 Compare September 19, 2022 11:51
@odubajDT
working version
4ea6af0 
Signed-off-by: odubajDT <[email protected]>
thschue
thschue previously requested changes Sep 19, 2022
View reviewed changes
operator/PROJECT Show resolved Hide resolved
operator/api/v1alpha1/service_types.go Outdated Show resolved Hide resolved
@odubajDT
finish service when serviceRun is finished
169f10e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix
515dbc1 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
last nitpicks
e721879 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT requested a review from a team as a code owner September 20, 2022 05:54
@odubajDT odubajDT dismissed thschue’s stale review September 20, 2022 05:55

will be fixed later

@odubajDT odubajDT merged commit c714ecc into main Sep 20, 2022
This was referenced Sep 29, 2022
Closed
Closed
Closed
Closed
Closed
Merged
Merged
@thschue thschue deleted the feat/10/bootstrap-service-controller branch October 13, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl left review comments

@RealAnna RealAnna RealAnna approved these changes

@thschue thschue thschue left review comments

@thisthat thisthat Awaiting requested review from thisthat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrap Service Controller
4 participants
@odubajDT @bacherfl @thschue @RealAnna