Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): support combination of OR criteria in SLO converter #2023

Merged
merged 4 commits into from
Sep 6, 2023
Merged

feat(metrics-operator): support combination of OR criteria in SLO converter #2023

merged 4 commits into from
Sep 6, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Sep 5, 2023

Changes

  • support conversion of multiple criteria elements in pass criteria
  • unit tests
  • renamed converter parameters

Fixes: #2021

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 8607bec
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64f858eaf689c10008b7bafc
😎 Deploy Preview https://deploy-preview-2023--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@odubajDT odubajDT marked this pull request as ready for review September 5, 2023 09:08
@odubajDT odubajDT requested a review from a team as a code owner September 5, 2023 09:08
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2023 (c7b4168) into main (621c59d) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 84.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2023      +/-   ##
==========================================
+ Coverage   84.08%   84.17%   +0.08%     
==========================================
  Files         150      150              
  Lines        9525     9541      +16     
==========================================
+ Hits         8009     8031      +22     
+ Misses       1228     1224       -4     
+ Partials      288      286       -2     
Files Changed Coverage Δ
metrics-operator/converter/slo_converter.go 94.54% <83.87%> (+0.23%) ⬆️
metrics-operator/converter/sli_converter.go 95.52% <100.00%> (ø)

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.89% <ø> (-0.42%) ⬇️
lifecycle-operator 84.94% <ø> (ø)
metrics-operator 85.95% <84.37%> (+0.09%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: odubajDT <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odubajDT odubajDT merged commit aa430e7 into keptn:main Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support corner case in SLO converter with criteria combined with OR operator
3 participants