Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-operator): adapt to changes in DQL API #1948

Merged
merged 4 commits into from
Aug 28, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Aug 25, 2023

This PR adapts the DQL provider to be compatible with the latest version of the Dynatrace DQL API

Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@netlify
Copy link

netlify bot commented Aug 25, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 1146e79
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64e83ebdcb6fc30008581ad7
😎 Deploy Preview https://deploy-preview-1948--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #1948 (1146e79) into main (39db23e) will increase coverage by 1.21%.
Report is 4 commits behind head on main.
The diff coverage is 89.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1948      +/-   ##
==========================================
+ Coverage   84.08%   85.29%   +1.21%     
==========================================
  Files         141      129      -12     
  Lines        8702     8155     -547     
==========================================
- Hits         7317     6956     -361     
+ Misses       1127      986     -141     
+ Partials      258      213      -45     
Files Changed Coverage Δ
...ollers/common/providers/dynatrace/client/common.go 66.66% <0.00%> (ø)
...ollers/common/providers/dynatrace/dynatrace_dql.go 80.75% <91.11%> (-2.22%) ⬇️
...r/controllers/common/providers/dynatrace/common.go 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

Flag Coverage Δ
certificate-operator ?
lifecycle-operator 84.92% <ø> (ø)
metrics-operator 85.40% <89.58%> (-0.63%) ⬇️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review August 28, 2023 10:48
@bacherfl bacherfl requested a review from a team as a code owner August 28, 2023 10:48
@bacherfl bacherfl merged commit 88d693a into keptn:main Aug 28, 2023
@bacherfl bacherfl deleted the feat/adapt-dql-provider-to-api-changes branch August 28, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants