feat(metrics-operator): add new provider interface #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: realanna <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1943 +/- ##
==========================================
- Coverage 84.08% 83.85% -0.24%
==========================================
Files 141 141
Lines 8702 8750 +48
==========================================
+ Hits 7317 7337 +20
- Misses 1127 1150 +23
- Partials 258 263 +5
... and 5 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: realanna <[email protected]>
odubajDT
previously approved these changes
Aug 24, 2023
Signed-off-by: realanna <[email protected]>
bacherfl
reviewed
Aug 24, 2023
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: realanna <[email protected]>
bacherfl
reviewed
Aug 24, 2023
metrics-operator/controllers/common/providers/prometheus/prometheus_test.go
Outdated
Show resolved
Hide resolved
…theus_test.go Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]>
odubajDT
approved these changes
Aug 24, 2023
bacherfl
approved these changes
Aug 24, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.