Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix broken links #1921

Merged
merged 18 commits into from
Aug 22, 2023
Merged

docs: fix broken links #1921

merged 18 commits into from
Aug 22, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Aug 22, 2023 •
edited
Loading

This PR

  • fixes a few broken links in the new getting started guide
  • move the whole getting started guide with its assets into its own sub-directory to follow the existing folder structure
  • reverts 2 sections in the usecase files to their state on main branch prior to merging the new getting started guide -> merge/rebase artifacts
  • aligns the concepts and implementing sections in the left sidebar correctly

@mowies
docs: fix broken links
8f4636c 
Signed-off-by: Moritz Wiesinger <[email protected]>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 22, 2023
@netlify
Copy link

netlify bot commented Aug 22, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 40f1016
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64e4afd9c631670008dc93d3
😎 Deploy Preview https://deploy-preview-1921--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mowies added 17 commits August 22, 2023 12:01
@mowies
try to fix link
0249a87 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
revert back to previous sections that were done in #1868
3db61e9 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
align concepts section
36be0ec 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
try different assets paths
0acf65b 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix link
b7946c3 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix link on homepage
9e1a73c 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
try to fix link again?
5318d4d 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix more links
d049c9d 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix another link
dc0d07d 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix another link again
98a411d 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
try to align concepts section in the sidebar
c9afc48 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
try again
aa16a3f 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
remove root assets folder
35d50fb 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix some links that dont need the index file appended
fbf3366 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix some links that dont need the index file appended
69c1f0f 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
fix links to image
481128a 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
aling link with others in the same doc
40f1016 
Signed-off-by: Moritz Wiesinger <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mowies mowies marked this pull request as ready for review August 22, 2023 12:56
@mowies mowies requested review from a team as code owners August 22, 2023 12:56
@mowies mowies merged commit 44074a2 into main Aug 22, 2023
@mowies mowies deleted the fix-docs-links branch August 22, 2023 14:19
@keptn-bot keptn-bot mentioned this pull request Aug 22, 2023
Merged
@StackScribe
Copy link
Contributor

Nice job! I still have build errors in the other PRs that I think are related to this -- I'm continue to try to figure those out. Along the way, I noticed a few other things: #1929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@bacherfl bacherfl bacherfl approved these changes

@thisthat thisthat thisthat approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mowies @StackScribe @thisthat @bacherfl @RealAnna