Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup unused env variables in Makefile #1913

Merged
merged 1 commit into from
Aug 22, 2023
Merged

chore: cleanup unused env variables in Makefile #1913

merged 1 commit into from
Aug 22, 2023

Conversation

odubajDT
Copy link
Contributor

No description provided.

Verified

This commit was signed with the committer’s verified signature.
neogeek Scott Doxey
Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>
@odubajDT odubajDT requested a review from a team as a code owner August 22, 2023 06:41
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit e206ea5
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64e458969299ed00081cf966
😎 Deploy Preview https://deploy-preview-1913--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1913 (e206ea5) into main (fa2b54d) will decrease coverage by 0.10%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
- Coverage   83.90%   83.81%   -0.10%     
==========================================
  Files         141      141              
  Lines        8588     8588              
==========================================
- Hits         7206     7198       -8     
- Misses       1126     1132       +6     
- Partials      256      258       +2     

see 4 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.25% <ø> (-1.10%) ⬇️
lifecycle-operator 84.92% <ø> (ø)
metrics-operator 85.37% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title chore: cleanup unused env variables chore: cleanup unused env variables in Makefile Aug 22, 2023
@odubajDT odubajDT merged commit 1ddd089 into keptn:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants