-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: move docs branch sections from readme to contrib guide #1902
Conversation
Signed-off-by: Shivang Shandilya <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good in general, but please remove the copied sections from the readme and instead link to the newly created sections so that we don't have duplicated content. That should improve maintainability in the future.
Also, please run |
page
branch and main
branch.Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Signed-off-by: Shivang Shandilya <[email protected]>
Signed-off-by: Shivang Shandilya <[email protected]>
@mowies take a look at the new changes I made I have tried changing the content a bit so it doesn't look duplicated. Reason: I found these ques to answer queries that a new contributor might have when contributing to docs, we can further add ques if in future some new queries arise. I was quite hesitant to make this change but I think its a good addition overall but I can remove it if you say otherwise 😅 |
Signed-off-by: Shivang Shandilya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, i would just put the FAQ content into the other sections
Signed-off-by: Shivang Shandilya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a slightly different version. See if you like it :)
Signed-off-by: Moritz Wiesinger <[email protected]>
@ShivangShandilya I fixed the markdownlint issues. If you apply my suggestion, also the last error should get fixed. |
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
If |
Signed-off-by: Shivang Shandilya <[email protected]>
This is a nice start but it is supposed to be in the "Documentation contributions" section of the "Contributing" guide that is accessed from the "Contributing" tab on the Keptn screen. To implement this:
Add your text after this header block, with one blank line after the header box. |
You need an introductory paragraph that begins with a good topic sentence. Something like "Keptn documentation is versioned. By default, the version for the current Keptn release is displayed on the documentation page but users can select other versions from the Then maybe use the first list you have, but I would put the Official Documentation first, followed by the Development branch, then add a third item for "Documentation for previous releases. I'll comment your file further with some other suggestions. Do not slavishly follow my suggestions -- they have too much duplicated information. I think it's good information but you can decide where it goes. It may make sense to have the bullet list in the introduction be very brief: just "Latest", "Development", "Old versions", and "Contribute" then move all the details about each into the sections below. |
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
I'll just work on this ASAP, sorry for taking so long 🥲 |
Co-authored-by: Meg McRoberts <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Signed-off-by: Shivang Shandilya <[email protected]>
@StackScribe I have made some changes, please take a look. |
@ShivangShandilya this is 🚀 , if you fix the markdown errors we can merge this so everyone will finally know how to edit docs pages 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These suggestions should help you with the markdownlint errors @ShivangShandilya
Co-authored-by: Rakshit Gondwal <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Co-authored-by: Rakshit Gondwal <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Co-authored-by: Rakshit Gondwal <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Co-authored-by: Rakshit Gondwal <[email protected]> Signed-off-by: Shivang Shandilya <[email protected]>
Thanks @rakshitgondwal for helping me out here 🚀 |
Kudos, SonarCloud Quality Gate passed! |
thanks for your contribution @ShivangShandilya ! |
) Co-authored-by: Moritz Wiesinger <[email protected]> Co-authored-by: Meg McRoberts <[email protected]> Co-authored-by: Giovanni Liva <[email protected]> Co-authored-by: Rakshit Gondwal <[email protected]>
This PR closes: #1863
This PR adds Publishing Section in our docs contributing guide as it gives a pretty good idea in what happens when things are merged in
page
andmain
branch.