-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add Evaluation instructions #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealAnna
force-pushed
the
chore/readme
branch
from
October 18, 2022 12:25
001afc5
to
f2fc9a6
Compare
bacherfl
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/keptnevaluationdefinition.yaml
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/keptnevaluationdefinition.yaml
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/keptnevaluationdefinition.yaml
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/keptnevaluationprovider.yaml
Outdated
Show resolved
Hide resolved
bacherfl
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/post-deployment-tasks.yaml
Show resolved
Hide resolved
bacherfl
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/post-deployment-tasks.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
…n/keptnevaluationdefinition.yaml Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]>
…n/keptnevaluationdefinition.yaml Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]>
…n/keptnevaluationdefinition.yaml Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]>
…n/post-deployment-tasks.yaml Co-authored-by: Florian Bacher <[email protected]> Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
RealAnna
force-pushed
the
chore/readme
branch
from
October 19, 2022 09:58
7a61aeb
to
104c6bd
Compare
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: RealAnna <[email protected]>
thisthat
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/README.md
Outdated
Show resolved
Hide resolved
thisthat
reviewed
Oct 19, 2022
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
thisthat
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/post-deployment-tasks.yaml
Show resolved
Hide resolved
Signed-off-by: RealAnna <[email protected]>
bacherfl
reviewed
Oct 19, 2022
examples/observability/assets/podtatohead-deployment-evaluation/post-deployment-tasks.yaml
Show resolved
Hide resolved
Signed-off-by: RealAnna <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: RealAnna <[email protected]>
bacherfl
previously approved these changes
Oct 19, 2022
odubajDT
reviewed
Oct 20, 2022
odubajDT
reviewed
Oct 20, 2022
odubajDT
reviewed
Oct 20, 2022
odubajDT
previously approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments, but otherwise lgtm :)
Signed-off-by: RealAnna <[email protected]>
thschue
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thisthat
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RealAnna [email protected]
Resolves #182