Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: contrib: DCO #1886

Merged
merged 7 commits into from
Aug 25, 2023
Merged

docs: contrib: DCO #1886

merged 7 commits into from
Aug 25, 2023

Conversation

StackScribe
Copy link
Contributor

Closes #1884

This PR:

  • Combines/rewrites info about working with DCO from the main CONTRIBUTING.md and docs CONTRIBUTING.md files
  • Replaces the DCO content in the main CONTRIBUTING.md file with a link to this page
  • Replaces the DCO content in the main CONTRIBUTING.md file with a link to this page

@StackScribe
docs: contrib: DCO
567e553 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Aug 15, 2023
@StackScribe StackScribe added this to the 0.9 milestone Aug 15, 2023
@StackScribe StackScribe self-assigned this Aug 15, 2023
@StackScribe StackScribe requested review from a team as code owners August 15, 2023 02:54
@netlify
Copy link

netlify bot commented Aug 15, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 40122f9
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64e69d47bb92a60009cc0bc1
😎 Deploy Preview https://deploy-preview-1886--keptn-lifecycle-toolkit.netlify.app/contribute/general/dco
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@StackScribe
markdownlint-fix
25ee8ad 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
space
e5d7910 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
small edit
107db95 
Signed-off-by: Meg McRoberts <[email protected]>
thisthat
thisthat previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some suggestion to let readers understanding what's the meaning of DCO, otherwise LGTM :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
agardnerIT and others added 3 commits August 24, 2023 09:58
@agardnerIT @thisthat
Update CONTRIBUTING.md
5a00f88 
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
@agardnerIT @thisthat
Update docs/CONTRIBUTING.md
1c18c96 
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
@agardnerIT @bacherfl
Update docs/content/en/contribute/general/dco/_index.md
40122f9 
Co-authored-by: Florian Bacher <[email protected]>
Signed-off-by: Adam Gardner <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thisthat thisthat merged commit 2fdd9cb into keptn:main Aug 25, 2023
@keptn-bot keptn-bot mentioned this pull request Aug 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacherfl bacherfl bacherfl left review comments

@agardnerIT agardnerIT agardnerIT approved these changes

@thisthat thisthat thisthat approved these changes

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.8.3
Development

Successfully merging this pull request may close these issues.

DCO info
4 participants
@StackScribe @thisthat @bacherfl @agardnerIT