Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lifecycle-operator): avoid setting the overall state of an App or WorkloadInstance between state transitions #1871

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Aug 10, 2023

Closes #1870

Signed-off-by: Florian Bacher <[email protected]>
@netlify
Copy link

netlify bot commented Aug 10, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit f2fd316
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64dcad247f59830008ca300a
😎 Deploy Preview https://deploy-preview-1871--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1871 (f2fd316) into main (4407fc4) will increase coverage by 0.02%.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1871      +/-   ##
==========================================
+ Coverage   83.52%   83.55%   +0.02%     
==========================================
  Files         136      136              
  Lines        8431     8427       -4     
==========================================
- Hits         7042     7041       -1     
+ Misses       1131     1129       -2     
+ Partials      258      257       -1     
Files Changed Coverage Δ
...ecycle-operator/controllers/common/phasehandler.go 80.95% <ø> (-0.30%) ⬇️
...ontrollers/lifecycle/keptnappversion/controller.go 82.30% <75.00%> (+1.85%) ⬆️
Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.07% <0.00%> (+0.32%) ⬆️
lifecycle-operator 84.92% <75.00%> (+0.04%) ⬆️
metrics-operator 83.62% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl changed the title chore: added logs to debug flaky test fix: avoid setting the overall state of an App or WorkloadInstance between state transitions Aug 11, 2023
@bacherfl bacherfl marked this pull request as ready for review August 11, 2023 07:43
@bacherfl bacherfl requested a review from a team as a code owner August 11, 2023 07:43
Signed-off-by: Florian Bacher <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl changed the title fix: avoid setting the overall state of an App or WorkloadInstance between state transitions fix(lifecycle-operator): avoid setting the overall state of an App or WorkloadInstance between state transitions Aug 16, 2023
@bacherfl bacherfl merged commit ee0b085 into keptn:main Aug 16, 2023
@bacherfl bacherfl deleted the fix/flaky-test branch August 16, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inspect flaky e2e test
4 participants