Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support external cert-manager #1864

Merged
merged 9 commits into from
Aug 10, 2023
Merged

chore: support external cert-manager #1864

merged 9 commits into from
Aug 10, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Aug 9, 2023

Changes

  • added ca-injection annotations to webhooks and CRDs
  • update documentation how to use external cert-manager

Fixes: #1809

@github-actions github-actions bot added documentation Improvements or additions to documentation helm labels Aug 9, 2023
@netlify
Copy link

netlify bot commented Aug 9, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 9a1fa89
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64d4b2d88f95a40008a1a918
😎 Deploy Preview https://deploy-preview-1864--keptn-lifecycle-toolkit.netlify.app/docs/install/cert-manager
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #1864 (9a1fa89) into main (f25b24d) will decrease coverage by 24.91%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1864       +/-   ##
===========================================
- Coverage   83.50%   58.59%   -24.91%     
===========================================
  Files         136       35      -101     
  Lines        8292     2408     -5884     
===========================================
- Hits         6924     1411     -5513     
+ Misses       1114      860      -254     
+ Partials      254      137      -117     

see 115 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
lifecycle-operator ?
metrics-operator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review August 9, 2023 09:37
@odubajDT odubajDT requested review from a team as code owners August 9, 2023 09:37
docs/content/en/docs/install/cert-manager.md Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/concepts/architecture/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/k8s.md Outdated Show resolved Hide resolved
thisthat
thisthat previously approved these changes Aug 9, 2023
odubajDT and others added 7 commits August 9, 2023 14:20
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: odubajDT <[email protected]>
mowies
mowies previously approved these changes Aug 9, 2023
@StackScribe
Copy link
Contributor

Lines 17-22 need a little rewrite -- something like the following although I may have screwed up the termology a bit:

KLT also works well with the
cert-manager.io
controller to support other certificate issuers.
If you are already using a different cert-manager,
you can continue to use that cert-manager for other components
and use the KLT cert-manager just for KLT activities
or you can disable the KLT cert-manager
and configure KLT to use the cert-manager.io controller.

Signed-off-by: odubajDT <[email protected]>
@StackScribe
Copy link
Contributor

StackScribe commented Aug 10, 2023

Need to modify the cert-manager page under Architecture.

First, end the first section with just the mention that you can use an alternate cert-manager and say "See below" or something -- remove the link to the instructions.

Then add a section at the end of this page. Something on the order of:

Using KLT with another cert-manager

KLT can co-exist with cert-manager.io
or can be configured to use cert-manager.io instead of the built-in KLT cert-manager;
see Use Keptn with cert-manager.io
for instructions.

When KLT is initialized on the namespace,
it checks whether the built-in cert-manager has been disabled.

  • If it has not been disabled, KLT uses it.
  • If the built-in cert-manager has been disabled,
    KLT looks for the cert-manager.io Certificate and Issuer resources
    and configures the Webhook to use that cert-manager instead.
    Note that you can not modify the cert-manger on a running KLT instance.

Question: can they modify, say, the dnsNames fields in the Certificate
or the spec for the Issuer without reinstalling KLT?

Copy link
Contributor

@StackScribe StackScribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. I made a couple suggestions for you to consider -- just to provide a bit more context here

Co-authored-by: Moritz Wiesinger <[email protected]>
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.1% 0.1% Duplication

@odubajDT
Copy link
Contributor Author

Nicely done. I made a couple suggestions for you to consider -- just to provide a bit more context here

Thank you, applied some of them, but as this is still in progress, it will change in the time :)

@odubajDT odubajDT merged commit 50dac48 into keptn:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation helm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External cert manager page needs a rewrite
6 participants