-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: support external cert-manager #1864
chore: support external cert-manager #1864
Conversation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1864 +/- ##
===========================================
- Coverage 83.50% 58.59% -24.91%
===========================================
Files 136 35 -101
Lines 8292 2408 -5884
===========================================
- Hits 6924 1411 -5513
+ Misses 1114 860 -254
+ Partials 254 137 -117 see 115 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: odubajDT <[email protected]>
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Lines 17-22 need a little rewrite -- something like the following although I may have screwed up the termology a bit: KLT also works well with the |
Signed-off-by: odubajDT <[email protected]>
Need to modify the cert-manager page under Architecture. First, end the first section with just the mention that you can use an alternate cert-manager and say "See below" or something -- remove the link to the instructions. Then add a section at the end of this page. Something on the order of: Using KLT with another cert-managerKLT can co-exist with cert-manager.io When KLT is initialized on the namespace,
Question: can they modify, say, the dnsNames fields in the Certificate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done. I made a couple suggestions for you to consider -- just to provide a bit more context here
Co-authored-by: Moritz Wiesinger <[email protected]> Signed-off-by: odubajDT <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thank you, applied some of them, but as this is still in progress, it will change in the time :) |
Changes
ca-injection
annotations to webhooks and CRDsFixes: #1809