Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics-operator): add AnalysisDefinition CRD #1823

Merged
merged 21 commits into from
Aug 8, 2023
Merged

feat(metrics-operator): add AnalysisDefinition CRD #1823

merged 21 commits into from
Aug 8, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Aug 2, 2023 •
edited
Loading

Changes

  • bootstrap AnalysisDefinition CRD
  • introduce validation webhook for certain fields in AnalysisDefinition (see linked ticket for more details)
  • introduce unit tests for validation webhook
  • introduce integration tests for validating webhook and new CR
  • introduce sample for newly created CRD
  • re-generated CRD docs

Fixes: #1758

@github-actions github-actions bot added documentation Improvements or additions to documentation metrics-operator labels Aug 2, 2023
@netlify
Copy link

netlify bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 1cc5021
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64d2348b5113d3000897d2b3
😎 Deploy Preview https://deploy-preview-1823--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/metrics/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 2, 2023 •
edited
Loading

Codecov Report

Merging #1823 (1cc5021) into main (768b3e9) will decrease coverage by 24.37%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1823       +/-   ##
===========================================
- Coverage   83.45%   59.09%   -24.37%     
===========================================
  Files         132       35       -97     
  Lines        8215     2408     -5807     
===========================================
- Hits         6856     1423     -5433     
+ Misses       1106      848      -258     
+ Partials      253      137      -116

see 110 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
lifecycle-operator ?
metrics-operator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review August 3, 2023 07:55
@odubajDT odubajDT requested review from a team as code owners August 3, 2023 07:55
@github-actions github-actions bot added the ops label Aug 3, 2023
bacherfl
bacherfl previously approved these changes Aug 3, 2023
View reviewed changes
thisthat
thisthat reviewed Aug 3, 2023
View reviewed changes
metrics-operator/api/v1alpha3/analysisdefinition_webhook.go Show resolved Hide resolved
metrics-operator/api/v1alpha3/analysisdefinition_types.go Outdated Show resolved Hide resolved
metrics-operator/api/v1alpha3/analysisdefinition_types.go Outdated Show resolved Hide resolved
metrics-operator/api/v1alpha3/analysisdefinition_types.go Outdated Show resolved Hide resolved
metrics-operator/api/v1alpha3/analysisdefinition_types.go Outdated Show resolved Hide resolved
metrics-operator/api/v1alpha3/analysisdefinition_webhook.go Outdated Show resolved Hide resolved
metrics-operator/config/samples/metrics_v1alpha3_analysisdefinition.yaml Outdated Show resolved Hide resolved
metrics-operator/api/v1alpha3/analysisdefinition_webhook.go Outdated Show resolved Hide resolved
odubajDT added 8 commits August 8, 2023 11:32
@odubajDT
fix htmltest
0d0fcce 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
add docs comments
5d24fe3 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
polish docs comments + add additional check for score validation
bcb0981 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
rework accoring to discussions
9a7669e 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
16c711c 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix docs
f7d85f0 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
pr review
80fcfc4 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix tests
8dbc16d 
Signed-off-by: odubajDT <[email protected]>
@github-actions github-actions bot added the helm label Aug 8, 2023
@odubajDT
fix test
925d5de 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
fix pr review
cd8421e 
Signed-off-by: odubajDT <[email protected]>
@mowies mowies changed the title feat(metrics-operator): bootstrap AnalysisDefinition CRD feat(metrics-operator): add AnalysisDefinition CRD Aug 8, 2023
mowies
mowies previously approved these changes Aug 8, 2023
View reviewed changes
bacherfl
bacherfl previously approved these changes Aug 8, 2023
View reviewed changes
@odubajDT
pr review
1cc5021 
Signed-off-by: odubajDT <[email protected]>
@odubajDT odubajDT dismissed stale reviews from bacherfl and mowies via 1cc5021 August 8, 2023 12:26
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@odubajDT odubajDT merged commit adf4621 into keptn:main Aug 8, 2023
This was referenced Aug 8, 2023
Closed
Merged
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Aug 9, 2023
@odubajDT @StackScribe
feat(metrics-operator): add AnalysisDefinition CRD (keptn#1823)
512a8ca 
Signed-off-by: odubajDT <[email protected]>
@keptn-bot keptn-bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna left review comments

@StackScribe StackScribe StackScribe left review comments

@mowies mowies mowies approved these changes

@bacherfl bacherfl bacherfl approved these changes

@thisthat thisthat thisthat left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation helm metrics-operator ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add AnalysisDefinition CRD for SLO targets and totalScore
6 participants
@odubajDT @thisthat @bacherfl @StackScribe @mowies @RealAnna