feat(metrics-operator): add AnalysisValueTemplate CRD #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
added
documentation
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1822 +/- ##
==========================================
- Coverage 83.46% 83.44% -0.03%
==========================================
Files 135 136 +1
Lines 8290 8292 +2
==========================================
Hits 6919 6919
- Misses 1117 1118 +1
- Partials 254 255 +1
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
bacherfl
changed the title
Signed-off-by: Florian Bacher <[email protected]>
mowies
changed the title
…value-template # Conflicts: # docs/content/en/docs/crd-ref/metrics/v1alpha3/_index.md # metrics-operator/api/v1alpha3/zz_generated.deepcopy.go
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
removed
the
documentation
Signed-off-by: Florian Bacher <[email protected]>
github-actions
bot
added
the
documentation
Signed-off-by: Florian Bacher <[email protected]>
…value-template # Conflicts: # docs/content/en/docs/crd-ref/metrics/v1alpha3/_index.md # metrics-operator/PROJECT # metrics-operator/api/v1alpha3/zz_generated.deepcopy.go # metrics-operator/config/crd/kustomization.yaml
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
thisthat
reviewed
Aug 9, 2023
odubajDT
reviewed
Aug 9, 2023
odubajDT
reviewed
Aug 9, 2023
Signed-off-by: Florian Bacher <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
odubajDT
approved these changes
Aug 9, 2023
thisthat
approved these changes
Aug 9, 2023
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1759
This PR adds the
AnalysisValueTemplateCRD and a simple Kuttl test to verify that we can apply instances of this custom resource to a cluster.