fix(operator): sanitize app name annotation from uppercase to lowercase #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RealAnna
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1793 +/- ##
==========================================
- Coverage 63.54% 63.51% -0.03%
==========================================
Files 143 143
Lines 10918 10921 +3
==========================================
- Hits 6938 6937 -1
- Misses 3719 3722 +3
- Partials 261 262 +1
... and 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
thisthat
previously approved these changes
Jul 27, 2023
Signed-off-by: realanna <[email protected]>
odubajDT
approved these changes
Jul 27, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
thisthat
approved these changes
Jul 28, 2023
prakrit55
pushed a commit
to prakrit55/lifecycle-toolkit
that referenced
this pull request
Aug 3, 2023
…se (keptn#1793) Signed-off-by: realanna <[email protected]> Signed-off-by: Griffin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1790