Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add step field in KeptnMetric #1755

Merged
merged 6 commits into from
Jul 28, 2023
Merged

feat: add step field in KeptnMetric #1755

merged 6 commits into from
Jul 28, 2023

Conversation

rakshitgondwal
Copy link
Member

Fixes #1735

Changes made:

  • Added spec.range.step field in the KeptnMetric CRD.
  • Modified the existing validating webhook to check if the value inside the step can be parsed.

@netlify
Copy link

netlify bot commented Jul 20, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 9b94a02
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64ba96a9873bf80008b9c50f
😎 Deploy Preview https://deploy-preview-1755--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #1755 (8cbcd65) into main (92730ad) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1755      +/-   ##
==========================================
+ Coverage   63.50%   63.59%   +0.09%     
==========================================
  Files         143      143              
  Lines       10907    10923      +16     
==========================================
+ Hits         6927     6947      +20     
+ Misses       3719     3716       -3     
+ Partials      261      260       -1
Impacted Files Coverage Δ
metrics-operator/api/v1alpha3/keptnmetric_types.go 100.00% <ø> (ø)
...trics-operator/api/v1alpha3/keptnmetric_webhook.go 93.10% <100.00%> (+2.62%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.22% <ø> (+0.27%) ⬆️
lifecycle-operator 84.90% <ø> (ø)
metrics-operator 82.57% <100.00%> (+0.24%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rakshitgondwal rakshitgondwal marked this pull request as ready for review July 21, 2023 14:39
@rakshitgondwal rakshitgondwal requested a review from a team as a code owner July 21, 2023 14:39
bacherfl
bacherfl reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@bacherfl bacherfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation looks good to me - can you please also add new or adapt the existing Kuttl test scenarios`Then this PR should be ready to get merged :)

@rakshitgondwal
add kuttl tests
f338106 
Signed-off-by: Rakshit Gondwal <[email protected]>
@rakshitgondwal
fix yamllint err
8cbcd65 
Signed-off-by: Rakshit Gondwal <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

RealAnna
RealAnna approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RealAnna RealAnna merged commit 03ca7dd into keptn:main Jul 28, 2023
@keptn-bot keptn-bot mentioned this pull request Jul 28, 2023
Merged
prakrit55 pushed a commit to prakrit55/lifecycle-toolkit that referenced this pull request Aug 3, 2023
@rakshitgondwal @prakrit55
feat: add step field in KeptnMetric (keptn#1755)
7c4ba87 
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Griffin <[email protected]>
@keptn-bot keptn-bot mentioned this pull request Aug 3, 2023
Closed
@keptn-bot keptn-bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@bacherfl bacherfl bacherfl approved these changes

Assignees
No one assigned
Labels
metrics-operator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce step field for KeptnMetric
3 participants
@rakshitgondwal @bacherfl @RealAnna