Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: admit pod without creating KLT resources if owner of the pod is not supported #1752

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

bacherfl
Copy link
Member

Closes #1749

…not one of the supported ones

Signed-off-by: Florian Bacher <[email protected]>
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 900b2af
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64b8db59088432000856ef63
😎 Deploy Preview https://deploy-preview-1752--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1752 (95d3ee1) into main (077f0d5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1752      +/-   ##
==========================================
- Coverage   63.59%   63.59%   -0.01%     
==========================================
  Files         143      143              
  Lines       10925    10934       +9     
==========================================
+ Hits         6948     6953       +5     
- Misses       3716     3719       +3     
- Partials      261      262       +1     
Impacted Files Coverage Δ
operator/apis/lifecycle/v1alpha3/common/common.go 100.00% <100.00%> (ø)
...rator/webhooks/pod_mutator/pod_mutating_webhook.go 74.86% <100.00%> (+0.49%) ⬆️

... and 4 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 59.27% <ø> (-0.27%) ⬇️
lifecycle-operator 84.58% <100.00%> (+0.02%) ⬆️
metrics-operator 82.32% <ø> (ø)
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

bacherfl added 2 commits July 20, 2023 09:20
…not one of the supported ones

Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl marked this pull request as ready for review July 20, 2023 08:12
@bacherfl bacherfl requested a review from a team as a code owner July 20, 2023 08:12
Signed-off-by: Florian Bacher <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit f47ca50 into keptn:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pods with unsupported Owners cannot be scheduled if Keptn annotations/labels are present
4 participants