chore: fix minor security issues #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moritz Wiesinger <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1728 +/- ##
==========================================
+ Coverage 63.23% 63.54% +0.30%
==========================================
Files 130 143 +13
Lines 10219 10909 +690
==========================================
+ Hits 6462 6932 +470
- Misses 3548 3716 +168
- Partials 209 261 +52 see 17 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
RealAnna
approved these changes
Jul 18, 2023
bacherfl
approved these changes
Jul 18, 2023
This was referenced Aug 29, 2023
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes the latest failed security scans by fixing the following issues:
alpine-1.35.1LABEL_SELECTOR_KEYenv var in cert operator (which was picked up as a plaintext token env var by kubescape)github.com/docker/distributiontov2.8.2+incompatiblein schedulerProof:
https://github.com/keptn/lifecycle-toolkit/actions/runs/5584795645
Fixes:
Fixes #1545
Fixes #1720
Fixes #1695
Fixes #1659
Fixes #1616
Fixes #1576
Fixes #1522
Fixes #1485
Fixes #1442
Fixes #1413
Closes #1564