Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: migrate quality gates #1708

Merged
merged 21 commits into from
Aug 25, 2023
Merged

docs: migrate quality gates #1708

merged 21 commits into from
Aug 25, 2023

Conversation

StackScribe
Copy link
Contributor

@StackScribe StackScribe commented Jul 12, 2023 •
edited
Loading

closes #1609

  • How to migrate keptn v1 SLIs/SLOs to KLT metrics and evaluations
  • Moved basic info about implementing KeptnMetricsProvider to main docs; it is not specific to migration

@StackScribe
docs: migrate quality gates
b4b72ab 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe added the documentation Improvements or additions to documentation label Jul 12, 2023
@StackScribe StackScribe self-assigned this Jul 12, 2023
@StackScribe StackScribe requested review from a team as code owners July 12, 2023 09:29
@StackScribe StackScribe marked this pull request as draft July 12, 2023 09:29
@netlify
Copy link

netlify bot commented Jul 12, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 5c50d2d
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64e83d6fa86a780008c17dae
😎 Deploy Preview https://deploy-preview-1708--keptn-lifecycle-toolkit.netlify.app/docs/migrate/metrics-observe
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@StackScribe
markdownlint errors
e285e4d 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
xrefs
d19a372 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
markdownlint
1cd0000 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
DORA
722e862 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe marked this pull request as ready for review August 4, 2023 08:59
@StackScribe
Anna/Giovanni comments for migrate/metrics
a5a51d8 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
markdownlint xrefs
f612c5a 
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe
another xref
57ca8c0 
Signed-off-by: Meg McRoberts <[email protected]>
StackScribe and others added 12 commits August 8, 2023 20:53
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
530808b 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
5e94fb6 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
907b5eb 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
7aa3a18 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
3434e34 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
f860a84 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
fc9e477 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
bf6588c 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
de940e6 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/implementing/evaluatemetrics.md
c569ba8 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/migrate/metrics-observe/_index.md
59eae57 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe @odubajDT
Update docs/content/en/docs/migrate/metrics-observe/_index.md
0c85467 
Signed-off by: Meg McRoberts [email protected]

Co-authored-by: odubajDT <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
thisthat
thisthat previously approved these changes Aug 21, 2023
View reviewed changes
@odubajDT
Copy link
Contributor

Nice work, approved :)

@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

thisthat
thisthat reviewed Aug 25, 2023
View reviewed changes
docs/content/en/docs/migrate/metrics-observe/_index.md
Comment on lines +27 to +32
> **Note**
The full SLO capabilities
provided by Keptn v1 such as weighting and scoring
are currently under development for KLT.
You can follow and participate in the design and implementation process at
[Github epic 1785](https://github.com/keptn/lifecycle-toolkit/pull/1785).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a ticket to don't forget removing this piece when we'll finish the implementation :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! When the implementation is complete, I'll need to rewrite this section plus we have a page about migrating SLO's to KLT where we can write up all the elegant details.

@thisthat thisthat merged commit 0cec244 into keptn:main Aug 25, 2023
@keptn-bot keptn-bot mentioned this pull request Aug 25, 2023
Merged
@StackScribe StackScribe deleted the 0710-sli branch September 2, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna left review comments

@agardnerIT agardnerIT agardnerIT left review comments

@thisthat thisthat thisthat approved these changes

@odubajDT odubajDT odubajDT approved these changes

Assignees

@StackScribe StackScribe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

how to define KeptnMetricsProvider resources for data sources
5 participants
@StackScribe @odubajDT @thisthat @agardnerIT @RealAnna