Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update Datadog API to query metrics for range #1615

Merged

Conversation

rakshitgondwal
Copy link
Member

@rakshitgondwal rakshitgondwal commented Jun 23, 2023

Partially Fixes (#1012)

Changes made:

  • Updated datadog.go to query metrics over a time frame.
  • Modified the tests accordingly.

@netlify
Copy link

netlify bot commented Jun 23, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 8830947
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64b77ff301171000096f21e4
😎 Deploy Preview https://deploy-preview-1615--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1615 (8830947) into main (077f0d5) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1615      +/-   ##
==========================================
- Coverage   63.59%   63.56%   -0.04%     
==========================================
  Files         143      143              
  Lines       10925    10936      +11     
==========================================
+ Hits         6948     6951       +3     
- Misses       3716     3722       +6     
- Partials      261      263       +2     
Impacted Files Coverage Δ
...or/controllers/common/providers/datadog/datadog.go 81.48% <100.00%> (+2.91%) ⬆️

... and 2 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 58.46% <ø> (-1.08%) ⬇️
lifecycle-operator 84.55% <ø> (ø)
metrics-operator 82.49% <100.00%> (+0.16%) ⬆️
scheduler 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rakshitgondwal rakshitgondwal marked this pull request as ready for review June 30, 2023 17:46
@rakshitgondwal rakshitgondwal requested a review from a team as a code owner June 30, 2023 17:46
@github-actions github-actions bot added the helm label Jul 7, 2023
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the PR looks good 👍 I would suggest adding a test to verify that if an interval is incorrectly set (for some reasons) we will fail without querying DD

@github-actions github-actions bot removed the helm label Jul 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rakshitgondwal rakshitgondwal requested a review from thisthat July 20, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants