-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update Datadog API to query metrics for range #1615
feat: update Datadog API to query metrics for range #1615
Conversation
Signed-off-by: Rakshit Gondwal <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1615 +/- ##
==========================================
- Coverage 63.59% 63.56% -0.04%
==========================================
Files 143 143
Lines 10925 10936 +11
==========================================
+ Hits 6948 6951 +3
- Misses 3716 3722 +6
- Partials 261 263 +2
... and 2 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
metrics-operator/controllers/common/providers/datadog/datadog_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Rakshit Gondwal <[email protected]>
Signed-off-by: Rakshit Gondwal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the PR looks good 👍 I would suggest adding a test to verify that if an interval is incorrectly set (for some reasons) we will fail without querying DD
Signed-off-by: Rakshit Gondwal <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Partially Fixes (#1012)
Changes made:
datadog.go
to query metrics over a time frame.