feat(operator): adapt TaskDefinition validation webhook to consider python and deno runtime #1534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime and deno functionality Signed-off-by: geoffrey1330 <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bacherfl
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1534 +/- ##
==========================================
+ Coverage 63.04% 63.22% +0.18%
==========================================
Files 142 142
Lines 10779 10794 +15
==========================================
+ Hits 6796 6825 +29
+ Misses 3724 3714 -10
+ Partials 259 255 -4
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
bacherfl
reviewed
Jun 7, 2023
odubajDT
reviewed
Jun 7, 2023
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
|
Nice work! Can you please add some integration tests and also adapt the failing unit tests ? Thank you! |
Alright I will do that |
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go
Outdated
Show resolved
Hide resolved
operator/apis/lifecycle/v1alpha3/keptntaskdefinition_webhook_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
The error with unit tests should be resolved after fixing these @geoffrey1330
Signed-off-by: geoffrey1330 <[email protected]>
Signed-off-by: geoffrey1330 <[email protected]>
|
Hello @geoffrey1330 nice work! The PR looks good, can you just please check why the integration tests are failing? Thank you |
RealAnna
reviewed
Jun 12, 2023
test/integration/validate-taskdefinition/00-teststep-install.yaml
Outdated
Show resolved
Hide resolved
RealAnna
reviewed
Jun 12, 2023
Signed-off-by: RealAnna <[email protected]>
…ntime_functionality
Signed-off-by: geoffrey1330 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
RealAnna
approved these changes
Jun 12, 2023
odubajDT
approved these changes
Jun 12, 2023
|
Thank you for your contribution @geoffrey1330 :) |
Merged
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Jun 19, 2023
…ython and deno runtime (keptn#1534) Signed-off-by: RealAnna <[email protected]> Co-authored-by: RealAnna <[email protected]>
StackScribe
pushed a commit
to StackScribe/lifecycle-toolkit
that referenced
this pull request
Jun 22, 2023
…ython and deno runtime (keptn#1534) Signed-off-by: RealAnna <[email protected]> Co-authored-by: RealAnna <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1527 Added logic to the validation webhook to accommodate the new fields for python-runtime and deno functionality.
Signed-off-by: geoffrey1330 [email protected]