Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): explicitly define ImagePullPolicy of Job container to IfNotPresent #1509

Merged
merged 1 commit into from
Jun 1, 2023
Merged

chore(operator): explicitly define ImagePullPolicy of Job container to IfNotPresent #1509

merged 1 commit into from
Jun 1, 2023

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jun 1, 2023

No description provided.

@odubajDT odubajDT requested a review from a team as a code owner June 1, 2023 12:30
@netlify
Copy link

netlify bot commented Jun 1, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 7efea7a
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64788f830e7c85000808100a
😎 Deploy Preview https://deploy-preview-1509--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Merging #1509 (29b3f6b) into main (9eafb78) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   62.64%   62.68%   +0.04%     
==========================================
  Files         140      140              
  Lines       10696    10697       +1     
==========================================
+ Hits         6700     6705       +5     
+ Misses       3736     3733       -3     
+ Partials      260      259       -1     
Impacted Files Coverage Δ
...ator/controllers/lifecycle/keptntask/js_builder.go 70.14% <100.00%> (+0.22%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
certificate-operator 68.55% <ø> (ø)
component-tests 57.98% <100.00%> (+0.84%) ⬆️
lifecycle-operator 84.18% <100.00%> (+<0.01%) ⬆️
metrics-operator 81.66% <ø> (ø)
scheduler 30.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@odubajDT odubajDT merged commit bb916f3 into keptn:main Jun 1, 2023
@keptn-bot keptn-bot mentioned this pull request Jun 1, 2023
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants