Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operator): make use of status.jobName when searching for job in KeptnTask controller #1436

Merged
merged 2 commits into from
May 23, 2023
Merged

chore(operator): make use of status.jobName when searching for job in KeptnTask controller #1436

merged 2 commits into from
May 23, 2023

Conversation

odubajDT
Copy link
Contributor

Fixes: #1424

@netlify
Copy link

netlify bot commented May 19, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 879f446
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/646c8c51caffff0008a3af92
😎 Deploy Preview https://deploy-preview-1436--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1436 (e40c46b) into main (6035e55) will decrease coverage by 2.66%.
The diff coverage is 91.66%.

❗ Current head e40c46b differs from pull request most recent head 879f446. Consider uploading reports for the commit 879f446 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1436      +/-   ##
==========================================
- Coverage   61.60%   58.94%   -2.66%     
==========================================
  Files         137       99      -38     
  Lines       10473     8755    -1718     
==========================================
- Hits         6452     5161    -1291     
+ Misses       3768     3438     -330     
+ Partials      253      156      -97     
Impacted Files Coverage Δ
...ator/controllers/lifecycle/keptntask/controller.go 52.70% <66.66%> (-2.25%) ⬇️
...perator/apis/lifecycle/v1alpha3/keptntask_types.go 97.59% <100.00%> (ø)
.../controllers/lifecycle/keptntask/function_utils.go 79.13% <100.00%> (ø)
...rator/controllers/lifecycle/keptntask/job_utils.go 43.24% <100.00%> (+2.70%) ⬆️

... and 41 files with indirect coverage changes

Flag Coverage Δ
certificate-operator ?
component-tests 60.11% <88.88%> (+1.01%) ⬆️
lifecycle-operator 83.38% <66.66%> (+0.24%) ⬆️
metrics-operator ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@odubajDT odubajDT marked this pull request as ready for review May 19, 2023 09:09
@odubajDT odubajDT requested a review from a team as a code owner May 19, 2023 09:09
RealAnna
RealAnna previously approved these changes May 23, 2023
odubajDT added 2 commits May 23, 2023 11:49
Signed-off-by: odubajDT <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.5% 5.5% Duplication

@odubajDT odubajDT merged commit 28dd6b7 into keptn:main May 23, 2023
@keptn-bot keptn-bot mentioned this pull request May 23, 2023
StackScribe pushed a commit to StackScribe/lifecycle-toolkit that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look up Job for a KeptnTask using status.jobName
3 participants