-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cert-manager): additional options for targeting WebhookConfigurations and CRDs #1276
Conversation
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
✅ Deploy Preview for keptn-lifecycle-toolkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1276 +/- ##
==========================================
+ Coverage 61.22% 61.44% +0.21%
==========================================
Files 138 143 +5
Lines 10471 10733 +262
==========================================
+ Hits 6411 6595 +184
- Misses 3807 3878 +71
- Partials 253 260 +7
... and 6 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…feat/cert-operator-config
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
…config # Conflicts: # klt-cert-manager/controllers/keptnwebhookcontroller/webhook_cert_controller_test.go # klt-cert-manager/go.mod # klt-cert-manager/go.sum
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
# Conflicts: # klt-cert-manager/go.mod
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
I guess you need to rebase to master to make the helm validation check to pass |
klt-cert-manager/controllers/keptnwebhookcontroller/resource_retriever.go
Show resolved
Hide resolved
Co-authored-by: Giovanni Liva <[email protected]> Signed-off-by: Florian Bacher <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR adds the additional configuration option of strictly defining which Mutating/Validating Webhooks and CustomResourceDefinitions should be retrieved and extended with the generated certificate.
This can be done by using the following struct when creating a
KeptnWebhookCertificateReconciler
:This is intended for use cases where the
KeptnWebhookCertificateReconciler
will be used as a library in other operators. Using the newly introduced options, operators using this will not requireget,list,update
permissions for allWebhookConfigurations
andCustomResourceDefinitions
, but can rely onClusterRoles
giving them access to a strictly defined set of resources, specified by theresourceNames
in theClusterRoles