Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace cert-manager #1210

Merged
merged 44 commits into from
Apr 18, 2023
Merged

docs: replace cert-manager #1210

merged 44 commits into from
Apr 18, 2023

Conversation

StackScribe
Copy link
Contributor

Fixes #1205.
Preserves content of #1117

This PR adds a page to the Installation section with details about how to replace the default KLT customized cert-manager with another cert-manager of ones choice.

@StackScribe StackScribe added the documentation Improvements or additions to documentation label Apr 11, 2023
@StackScribe StackScribe self-assigned this Apr 11, 2023
@netlify
Copy link

netlify bot commented Apr 11, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit fcbb58e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/643d6df37f696d0008c91930
😎 Deploy Preview https://deploy-preview-1210--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
docs/content/en/docs/install/_index.md Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
docs/content/en/docs/install/cert-manager.md Outdated Show resolved Hide resolved
StackScribe and others added 4 commits April 12, 2023 00:54
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
@StackScribe StackScribe marked this pull request as ready for review April 13, 2023 09:05
Signed-off-by: Meg McRoberts <[email protected]>
…toolkit into 0411-cert-manager

Signed-off-by: Meg McRoberts [email protected]
agardnerIT
agardnerIT previously approved these changes Apr 14, 2023
Copy link
Contributor

@agardnerIT agardnerIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Thanks! When we say “you can delete the certificate”, can we add the code snippets to do so? As a non certificate expert, I’m unsure how to do this.

Other than that, it’s great

StackScribe and others added 13 commits April 17, 2023 02:50
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts [email protected]

Co-authored-by: Giovanni Liva <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
…toolkit into 0411-cert-manager

Signed-off-by: Meg McRoberts <[email protected]>
Signed-off-by: Meg McRoberts <[email protected]>
…toolkit into 0411-cert-manager

Signed-off-by: Meg McRoberts [email protected]
Signed-off-by: Meg McRoberts <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@StackScribe StackScribe merged commit a84cbc7 into keptn:main Apr 18, 2023
@StackScribe StackScribe deleted the 0411-cert-manager branch April 18, 2023 11:03
@keptn-bot keptn-bot mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explain custom cert-manager
4 participants