Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Add commit hash, buildtime, buildversion to OTel resource attributes #121

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Oct 5, 2022

Signed-off-by: Giovanni Liva [email protected]

@thisthat thisthat marked this pull request as draft October 5, 2022 09:02
@thisthat thisthat force-pushed the feat/117/pass-build-info branch from e394607 to 7031783 Compare October 6, 2022 06:59
@thisthat thisthat marked this pull request as ready for review October 6, 2022 07:00
@thisthat thisthat changed the title feat(operator): Add commit hash, buildtime, buildversion and print at startup feat(operator): Add commit hash, buildtime, buildversion to OTel resource attributes Oct 6, 2022
odubajDT
odubajDT previously approved these changes Oct 6, 2022
operator/Makefile Outdated Show resolved Hide resolved
Signed-off-by: Giovanni Liva <[email protected]>
Copy link
Contributor

@thschue thschue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thschue thschue merged commit 5a2ef61 into main Oct 6, 2022
@thschue thschue deleted the feat/117/pass-build-info branch October 6, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants