Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added example for autoscaling using KeptnMetric #1173

Merged
merged 8 commits into from
Apr 5, 2023

Conversation

bacherfl
Copy link
Member

@bacherfl bacherfl commented Apr 3, 2023

Closes #1135

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 3, 2023
@netlify
Copy link

netlify bot commented Apr 3, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 190251f
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/642d0f91d0a3030008e895f2
😎 Deploy Preview https://deploy-preview-1173--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Florian Bacher <[email protected]>
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1173 (c08d3cc) into main (c2b0fa3) will increase coverage by 0.24%.
The diff coverage is n/a.

❗ Current head c08d3cc differs from pull request most recent head 98a6904. Consider uploading reports for the commit 98a6904 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
+ Coverage   59.03%   59.27%   +0.24%     
==========================================
  Files         128      128              
  Lines       10050    10162     +112     
==========================================
+ Hits         5933     6024      +91     
- Misses       3899     3918      +19     
- Partials      218      220       +2     

see 4 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.50% <ø> (-0.65%) ⬇️
lifecycle-operator 78.27% <ø> (ø)
metrics-operator 77.57% <ø> (ø)
scheduler 21.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@bacherfl bacherfl marked this pull request as ready for review April 5, 2023 08:36
thisthat
thisthat previously approved these changes Apr 5, 2023
Copy link
Member

@mowies mowies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments, LGTM overall 👍🏼

examples/support/metrics/README.md Outdated Show resolved Hide resolved
examples/support/metrics/README.md Outdated Show resolved Hide resolved
examples/support/metrics/README.md Outdated Show resolved Hide resolved
examples/support/metrics/README.md Outdated Show resolved Hide resolved
examples/support/metrics/deployment.yaml Outdated Show resolved Hide resolved
Signed-off-by: Florian Bacher <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bacherfl bacherfl merged commit 98dd248 into keptn:main Apr 5, 2023
@bacherfl bacherfl deleted the feat/metrics-demo branch April 5, 2023 11:39
@keptn-bot keptn-bot mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeptnMetrics E2E Demo
3 participants