Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can KeptnApp have preDeploymentTasks and postDeploymentEvaluations ? #1165

Closed
agardnerIT opened this issue Apr 1, 2023 · 2 comments · Fixed by #1254
Closed

Can KeptnApp have preDeploymentTasks and postDeploymentEvaluations ? #1165

agardnerIT opened this issue Apr 1, 2023 · 2 comments · Fixed by #1254
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@agardnerIT
Copy link
Contributor

The readme only shows KeptnApp level postDeploymentTasks and preDeploymentEvaluations.

Can a KeptnApp have preDeploymentTasks and postDeploymentEvaluations too?

Current readme example

---
apiVersion: lifecycle.keptn.sh/v1alpha3
kind: KeptnApp
metadata:
  name: podtato-head
  namespace: podtato-kubectl
spec:
  version: "1.3"
  revision: 1
  workloads:
  - name: podtato-head-left-arm
    version: 0.1.0
  - name: podtato-head-left-leg
    version: 1.2.3
  postDeploymentTasks:
  - post-deployment-hello
  preDeploymentEvaluations:    
  - my-prometheus-definition

Proposed readme example

---
apiVersion: lifecycle.keptn.sh/v1alpha3
kind: KeptnApp
metadata:
  name: podtato-head
  namespace: podtato-kubectl
spec:
  version: "1.3"
  revision: 1
  workloads:
  - name: podtato-head-left-arm
    version: 0.1.0
  - name: podtato-head-left-leg
    version: 1.2.3
  preDeploymentTasks:
  - pre-deployment-hello
  postDeploymentTasks:
  - post-deployment-hello
  preDeploymentEvaluations:    
  - my-prometheus-definition
  postDeploymentEvaluations:
  - my-prometheus-definition
@mowies mowies added question Further information is requested enhancement New feature or request labels Apr 20, 2023
@mowies
Copy link
Member

mowies commented Apr 20, 2023

Can a KeptnApp have preDeploymentTasks and postDeploymentEvaluations too?

Yes, it can :)

@mowies
Copy link
Member

mowies commented Apr 20, 2023

I created a quick PR to add your suggested changes @agardnerIT 👍🏼
#1254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants