Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve podtato example with HTTP service lookup #113

Merged
merged 6 commits into from
Oct 4, 2022

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Oct 4, 2022

Signed-off-by: Thomas Schuetz [email protected]

Thomas Schuetz added 2 commits October 4, 2022 15:22
Signed-off-by: Thomas Schuetz <[email protected]>
Signed-off-by: Thomas Schuetz <[email protected]>
@thschue thschue changed the title doc: add dns function doc: add http function Oct 4, 2022
@thschue thschue changed the title doc: add http function docs: add http function Oct 4, 2022
@thschue thschue marked this pull request as ready for review October 4, 2022 14:07
@thisthat thisthat changed the title docs: add http function docs: Improve podtato example with HTTP service lookup Oct 4, 2022
Signed-off-by: Thomas Schuetz <[email protected]>
thisthat
thisthat previously approved these changes Oct 4, 2022
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Signed-off-by: Thomas Schuetz <[email protected]>
Copy link
Contributor

@philipp-hinteregger philipp-hinteregger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

odubajDT
odubajDT previously approved these changes Oct 4, 2022
Signed-off-by: Thomas Schuetz <[email protected]>
@thschue thschue dismissed stale reviews from odubajDT and philipp-hinteregger via 8aca318 October 4, 2022 14:27
@thschue thschue merged commit 81b1236 into main Oct 4, 2022
@thschue thschue deleted the doc/add_dns_function branch October 13, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants