Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix examples, update podtatohead #1098

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Mar 23, 2023

This PR

  • Fixes some issues in the examples
  • Adds a sample KeptnConfig to the Deployment
  • Changes examples to use the upstream version of the podtatohead manifests

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 18a1fbd
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/641c40edf345de000823b5ab
😎 Deploy Preview https://deploy-preview-1098--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thschue thschue force-pushed the fix/jaeger-example-version branch from 18a1fbd to 214ac3b Compare March 23, 2023 12:08
@sonarcloud
Copy link

sonarcloud bot commented Mar 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1098 (214ac3b) into main (ddd3732) will decrease coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1098      +/-   ##
==========================================
- Coverage   59.03%   58.94%   -0.09%     
==========================================
  Files         126      126              
  Lines       10007    10007              
==========================================
- Hits         5908     5899       -9     
- Misses       3885     3891       +6     
- Partials      214      217       +3     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.82% <ø> (-0.66%) ⬇️
lifecycle-operator 78.40% <ø> (ø)
metrics-operator 77.35% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisthat
Copy link
Member

thisthat commented Mar 23, 2023

This also closes my PR #1090

@thschue thschue merged commit f581ed5 into main Mar 23, 2023
@thschue thschue deleted the fix/jaeger-example-version branch March 23, 2023 13:01
@keptn-bot keptn-bot mentioned this pull request Mar 23, 2023
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants