Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm-chart): fix missing values in the KLT helm chart #1082

Merged
merged 5 commits into from
Mar 22, 2023
Merged

fix(helm-chart): fix missing values in the KLT helm chart #1082

merged 5 commits into from
Mar 22, 2023

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 21, 2023 •
edited
Loading

This PR

  • adds some missing values that were not re-auto-generated before the v0.7.0 release
  • adds docs for the missing values
  • updates changes from released chart version 0.2.1
  • fixes a pipeline issue that prevented renamed files to be deleted during rsync

@netlify
Copy link

netlify bot commented Mar 21, 2023 •
edited
Loading

✅ Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 68d0459
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/641afa04c3483b00093575d6
😎 Deploy Preview https://deploy-preview-1082--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/lifecycle/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the ops label Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited
Loading

Codecov Report

Merging #1082 (50ea5f6) into main (71e9073) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1082   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files         126      126           
  Lines       10007    10007           
=======================================
  Hits         5900     5900           
  Misses       3890     3890           
  Partials      217      217
Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 60.47% <ø> (ø)
lifecycle-operator 78.40% <ø> (ø)
metrics-operator 77.35% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

RealAnna
RealAnna previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mowies mowies force-pushed the helm-chart-fixes branch from 94aa04d to 95d18d7 Compare March 22, 2023 12:44
mowies added 4 commits March 22, 2023 13:52
@mowies
fix: fix missing values in the KLT helm chart
3cae977 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
Trigger Build
b8b3fc6 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
add delete flag to rsync so that files are also removed when they nee…
58909da 
…d to be removed

Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies
update last chart things
68d0459 
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies force-pushed the helm-chart-fixes branch from 95d18d7 to 68d0459 Compare March 22, 2023 12:52
@mowies
regenerate helm readme
50ea5f6 
Signed-off-by: Moritz Wiesinger <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

RealAnna
RealAnna approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@RealAnna RealAnna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mowies mowies changed the title fix: fix missing values in the KLT helm chart fix(helm-chart): fix missing values in the KLT helm chart Mar 22, 2023
@mowies mowies merged commit 52311c1 into keptn:main Mar 22, 2023
@mowies mowies deleted the helm-chart-fixes branch March 22, 2023 13:13
@keptn-bot keptn-bot mentioned this pull request Mar 22, 2023
Merged
@thisthat thisthat mentioned this pull request Mar 22, 2023
Closed
aepfli pushed a commit to aepfli/lifecycle-toolkit that referenced this pull request Mar 30, 2023
@mowies @aepfli
fix(helm-chart): fix missing values in the KLT helm chart (keptn#1082)
f27a75a
@Indransh Indransh mentioned this pull request May 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RealAnna RealAnna RealAnna approved these changes

@thisthat thisthat thisthat approved these changes

@thschue thschue Awaiting requested review from thschue

@bacherfl bacherfl Awaiting requested review from bacherfl

@philipp-hinteregger philipp-hinteregger Awaiting requested review from philipp-hinteregger

Assignees
No one assigned
Labels
cert-manager documentation Improvements or additions to documentation helm metrics-operator ops scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mowies @thisthat @RealAnna